[Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx #3553

jeremy-jang · 2021-09-13T06:12:39Z

Description of Change

Fix ServerBase.DisplayName property and fix doxygen comments

API Changes

ACR: https://code.sec.samsung.net/jira/browse/TCSACR-462

TizenAPI-Bot · 2021-09-14T04:32:25Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-14T04:59:37Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-14T07:42:17Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-14T08:19:17Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-14T08:39:38Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-15T07:47:52Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-15T08:21:25Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-16T06:52:40Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 173, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-17T03:18:51Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 175, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-17T04:34:31Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 175, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-17T05:10:06Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 175, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

TizenAPI-Bot · 2021-09-17T05:20:11Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 175, Removed: 11, Changed: 6

Internal API Changed

Added: 33, Removed: 154, Changed: 2

WonyoungChoi · 2021-09-23T00:07:58Z

Please rebase with master branch again.

jeremy-jang · 2021-09-23T05:00:59Z

rebased

TizenAPI-Bot · 2021-09-23T05:04:37Z

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 1

Changed

+ /// <privilege>http://tizen.org/privilege/d2d.datasharing</privilege
/// <since_tizen>9</since_tizen
System.Void Tizen.Applications.ClientBase::TryDiscovery()

TizenAPI-Bot · 2021-09-23T10:25:09Z

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 1

Changed

+ /// <privilege>http://tizen.org/privilege/d2d.datasharing</privilege
/// <since_tizen>9</since_tizen
System.Void Tizen.Applications.ClientBase::TryDiscovery()

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add missing description of exceptions. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add missing setting _displayName. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

- Remove debugging logs. - Change log tag to "Tizen.Applications.Cion". Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

- Fix bad codes. - Update native API changes. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

ServerBase.OnConnentionRequest() -> ServerBase.OnConnectionRequest() Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix namespace to Tizen.Applications.Cion from Tizen.Applications. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

TizenAPI-Bot · 2021-10-12T07:02:29Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 101, Removed: 101, Changed: 0

…ocfx (#3553) * [Applications.Cion] Fix DisplayName property Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * [Applications.Cion] Fix doxygen comments Add missing description of exceptions. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix ServerBase.DisplayName property Add missing setting _displayName. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add privilege description at ClientBase.Discovery Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add some remarks FilePayload class Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add exception description of Client.TryDiscovery Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add exception description at FilePayload class Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add privlevel descriptions Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix typo Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix logging - Remove debugging logs. - Change log tag to "Tizen.Applications.Cion". Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add remarks exceptions at SecurityInfo class Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix native error code Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix interop delegate name Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix cion - Fix bad codes. - Update native API changes. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix typo Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix bug of ClientBase.SendPayloadAsync Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Adjust changes of native APIs Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix typo ServerBase.OnConnentionRequest() -> ServerBase.OnConnectionRequest() Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Add missing privilege requirements Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com> * Fix namespace Fix namespace to Tizen.Applications.Cion from Tizen.Applications. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

github-actions bot added the API9 Platform: Tizen 6.5 / TFM : tizen90 label Sep 13, 2021

TizenAPI-Bot added ACR Required Internal API Changed labels Sep 14, 2021

jeremy-jang force-pushed the acr branch from c67ab2e to 3414342 Compare September 23, 2021 05:00

TizenAPI-Bot removed the Internal API Changed label Sep 23, 2021

jeremy-jang added 9 commits October 12, 2021 15:43

[Applications.Cion] Fix DisplayName property

7383867

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

[Applications.Cion] Fix doxygen comments

265101b

Add missing description of exceptions. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix ServerBase.DisplayName property

23d4a75

Add missing setting _displayName. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add privilege description at ClientBase.Discovery

928c398

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add some remarks FilePayload class

31b899a

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add exception description of Client.TryDiscovery

492be28

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add exception description at FilePayload class

d300c99

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add privlevel descriptions

711b9ad

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix typo

1b7a425

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

jeremy-jang added 8 commits October 12, 2021 15:43

Fix logging

8138443

- Remove debugging logs. - Change log tag to "Tizen.Applications.Cion". Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add remarks exceptions at SecurityInfo class

1b9f952

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix native error code

1952b52

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix interop delegate name

a31bd2b

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix cion

642268c

- Fix bad codes. - Update native API changes. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix typo

72b1183

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix bug of ClientBase.SendPayloadAsync

939b115

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Adjust changes of native APIs

b5ccedd

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

jeremy-jang force-pushed the acr branch from 3c22c14 to db89993 Compare October 12, 2021 06:58

jeremy-jang added 3 commits October 12, 2021 16:00

Fix typo

b77e7af

ServerBase.OnConnentionRequest() -> ServerBase.OnConnectionRequest() Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Add missing privilege requirements

a243e8d

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

Fix namespace

db89993

Fix namespace to Tizen.Applications.Cion from Tizen.Applications. Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

jeremy-jang changed the title ~~[Applications.Cion] Fix ServerBase.DisplayName property and fix doxygen comments~~ [Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx Oct 12, 2021

WonyoungChoi approved these changes Oct 13, 2021

View reviewed changes

WonyoungChoi merged commit d63174d into Samsung:master Oct 13, 2021

jeremy-jang deleted the acr branch October 13, 2021 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx #3553

[Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx #3553

jeremy-jang commented Sep 13, 2021 •

edited

TizenAPI-Bot commented Sep 14, 2021

TizenAPI-Bot commented Sep 14, 2021

TizenAPI-Bot commented Sep 14, 2021

TizenAPI-Bot commented Sep 14, 2021

TizenAPI-Bot commented Sep 14, 2021

TizenAPI-Bot commented Sep 15, 2021

TizenAPI-Bot commented Sep 15, 2021

TizenAPI-Bot commented Sep 16, 2021

TizenAPI-Bot commented Sep 17, 2021

TizenAPI-Bot commented Sep 17, 2021

TizenAPI-Bot commented Sep 17, 2021

TizenAPI-Bot commented Sep 17, 2021

WonyoungChoi commented Sep 23, 2021

jeremy-jang commented Sep 23, 2021

TizenAPI-Bot commented Sep 23, 2021

Changed

TizenAPI-Bot commented Sep 23, 2021

Changed

TizenAPI-Bot commented Oct 12, 2021

[Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx #3553

[Applications.Cion] Fix namespace, ServerBase.DisplayName property, docfx #3553

Conversation

jeremy-jang commented Sep 13, 2021 • edited

Description of Change

API Changes

TizenAPI-Bot commented Sep 14, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 14, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 14, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 14, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 14, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 15, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 15, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 16, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 17, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 17, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 17, 2021

Public API Changed

Internal API Changed

TizenAPI-Bot commented Sep 17, 2021

Public API Changed

Internal API Changed

WonyoungChoi commented Sep 23, 2021

jeremy-jang commented Sep 23, 2021

TizenAPI-Bot commented Sep 23, 2021

Public API Changed

Changed

TizenAPI-Bot commented Sep 23, 2021

Public API Changed

Changed

TizenAPI-Bot commented Oct 12, 2021

Public API Changed

jeremy-jang commented Sep 13, 2021 •

edited