framework/task_manager : Add README and modify the description in he… #1864

jeongchanKim · 2018-06-14T00:55:11Z

…ader file

Add basic description in README.md
Modify wrong expression and add description in task_manager.h

seinfra · 2018-06-14T01:03:16Z

Target : [a970745c31a3a4426650dc1321e581b446e06597] - Code Rule Check (C++) OK.

seinfra · 2018-06-14T01:03:20Z

Target : [a970745c31a3a4426650dc1321e581b446e06597] - Code Rule Check OK.

sunghan-chang · 2018-06-14T01:29:35Z

framework/include/task_manager/task_manager.h

- * @param[in] permission the permission of task which request to register\n
+ * Only builtin task can be managed by task manager.
+ * @param[in] name the name of task which to be registered
+ * @param[in] permission the permission of task which to be registered\n


Above line does not have "\n" at end of line, but here it is. What is right?

sunghan-chang · 2018-06-14T01:32:15Z

framework/src/task_manager/README.md

+Further details are shown below.  
+
+## API List
+[API List](https://github.com/Samsung/TizenRT/tree/master/framework/include/task_manager)


Find APIs' details on header file, [task_manager.h](https://github.com/Samsung/TizenRT/tree/master/framework/include/task_manager/task_manager.h)

sunghan-chang · 2018-06-14T01:34:29Z

framework/src/task_manager/README.md

+[API List](https://github.com/Samsung/TizenRT/tree/master/framework/include/task_manager)
+
+## Task Manager Sample
+[Task Manager Sample](https://github.com/Samsung/TizenRT/tree/master/apps/examples/task_manager_sample)


## Sample Application [Task Manager Sample](https://github.com/Samsung/TizenRT/tree/master/apps/examples/task_manager_sample) covers all of above mentioned functionality. Please find sample's details on [README](....../README.md).

sunghan-chang · 2018-06-14T01:34:59Z

framework/src/task_manager/README.md

+
+Please find details in [here](#api-list).
+
+## How to enable


## Prerequisites

sunghan-chang · 2018-06-14T01:44:01Z

framework/src/task_manager/README.md

+
+Task manager manages the registered applications.  
+Supported features and APIs are shown below:  
+1. application registration APIs


How about below?

Features Functions

Regitration task_manger_register()

task_manager_unregister()

------------ -------------------------------

Please find https://github.com/Samsung/TizenRT/edit/master/apps/system/utils/README.md

sunghan-chang · 2018-06-14T01:58:51Z

framework/include/task_manager/task_manager.h

@@ -116,8 +116,9 @@ typedef struct task_info_list_s task_info_list_t;
 /**
 * @brief Request to register a task
 * @details @b #include <task_manager/task_manager.h>
- * @param[in] name the name of task which request to register
- * @param[in] permission the permission of task which request to register\n
+ * Only builtin task can be managed by task manager.


Could you leave a link of builtin feature?

Find apps/builtin/README.md to know how to use builtin task.

seinfra · 2018-06-14T02:18:21Z

Target : [c31555aeb89c2b6b7f81f5e763159e8c191e159f] - Code Rule Check OK.

seinfra · 2018-06-14T02:18:28Z

Target : [c31555aeb89c2b6b7f81f5e763159e8c191e159f] - Code Rule Check (C++) OK.

seinfra · 2018-06-14T02:28:06Z

Target : [dc483f3e6fc98824e1289cc24ab9ce62c419eea2] -

seinfra · 2018-06-14T02:28:16Z

Target : [dc483f3e6fc98824e1289cc24ab9ce62c419eea2] -

seinfra · 2018-06-14T02:33:11Z

Target : [8c4a08df58d7580577dd10a0ba31c89b5f61e899] - Code Rule Check OK.

seinfra · 2018-06-14T02:33:11Z

Target : [8c4a08df58d7580577dd10a0ba31c89b5f61e899] - Code Rule Check (C++) OK.

seinfra · 2018-06-14T04:38:05Z

Target : [cfd12b72d28cf0bae26f95c3bd8a2e2c3c563414] -

seinfra · 2018-06-14T04:38:09Z

Target : [cfd12b72d28cf0bae26f95c3bd8a2e2c3c563414] -

seinfra · 2018-06-14T04:43:08Z

Target : [e2fb86d850d9943b67eab73a8801798f31476fbf] -

seinfra · 2018-06-14T04:43:11Z

Target : [e2fb86d850d9943b67eab73a8801798f31476fbf] -

seinfra · 2018-06-14T04:48:23Z

Target : [0de0d07a137079af6021ae9f129c079aa5f3f8ab] - Code Rule Check (C++) OK.

seinfra · 2018-06-14T04:48:27Z

Target : [0de0d07a137079af6021ae9f129c079aa5f3f8ab] - Code Rule Check OK.

jeongarmy · 2018-06-14T04:55:27Z

It looks good

seinfra · 2018-06-14T04:59:12Z

Target : [ed05831893730b769f6b1b9bb13851ec9aa2d58c] -

seinfra · 2018-06-14T04:59:20Z

Target : [ed05831893730b769f6b1b9bb13851ec9aa2d58c] -

seinfra · 2018-06-14T05:03:28Z

Target : [5b25be27d9e42903b32000ab1c433bb409c6751f] - Code Rule Check (C++) OK.

seinfra · 2018-06-14T05:03:34Z

Target : [5b25be27d9e42903b32000ab1c433bb409c6751f] - Code Rule Check OK.

seinfra · 2018-06-14T05:58:27Z

Target : [611858650ed9ff31b04355b2cd96932eee0b438f] - Code Rule Check OK.

sunghan-chang · 2018-06-15T08:49:09Z

framework/src/task_manager/README.md

+
+### State
+Each Application can have four states.  
+![State Diagram](media/tm_state_diagram.png)


![State Diagram](https://github.com/Samsung/TizenRT/tree/master/docs/media/tm_state_diagram.png)

sunghan-chang · 2018-06-15T08:58:58Z

framework/src/task_manager/README.md

+	- TM_TASK_PERMISSION_DEDICATE : Only a task which requested to register that task can request the control to Task Manager
+
+### State
+Each Application can have four states.  


Task Manager manages each application with four states, unregistered, stop, running and paused.
Please find below how to move each state by APIs.

sunghan-chang · 2018-06-15T08:59:28Z

framework/src/task_manager/README.md

+ : Bixby can start the Alarm application through the task manager.  
+ : When Wi-Fi disconnection message is broadcasted, applications can receive the broadcast message.
+
+## Features


sunghan-chang · 2018-06-15T09:00:04Z

framework/src/task_manager/README.md

+Builtin information should follow the [format](https://github.com/Samsung/TizenRT/tree/master/apps/builtin).  
+
+
+Further details are shown below.  


Let's remove this line

seinfra · 2018-06-17T22:59:06Z

Target : [69f3234d1dbaae9346abb90d12137024ba1157da] - Code Rule Check (C++) OK.

seinfra · 2018-06-17T22:59:08Z

Target : [69f3234d1dbaae9346abb90d12137024ba1157da] - Code Rule Check OK.

seinfra · 2018-06-17T23:08:22Z

Target : [bd8faf797af17b75a953ab48628960001ebeb873] - Code Rule Check OK.

seinfra · 2018-06-17T23:09:08Z

Target : [bd8faf797af17b75a953ab48628960001ebeb873] - Code Rule Check (C++) OK.

seinfra · 2018-06-18T08:27:30Z

Target : [880288370e8fb7d272c3d012393588c590813f2a] - Code Rule Check OK.

seinfra · 2018-06-18T08:27:31Z

Target : [880288370e8fb7d272c3d012393588c590813f2a] - Code Rule Check (C++) OK.

seinfra · 2018-06-21T06:37:27Z

Target : [7273669bcf4bc0d43563c23d4714c1e4808c465c] -

seinfra · 2018-06-21T06:37:36Z

Target : [7273669bcf4bc0d43563c23d4714c1e4808c465c] -

seinfra · 2018-06-21T06:42:26Z

Target : [5d19f8f52c017aeefcd8e86dd29ecdba9cc7250e] - Code Rule Check (C++) OK.

seinfra · 2018-06-21T06:42:28Z

Target : [5d19f8f52c017aeefcd8e86dd29ecdba9cc7250e] - Code Rule Check OK.

sunghan-chang · 2018-06-22T06:28:10Z

framework/src/task_manager/README.md

+
+
+## Sample Application
+[Task Manager Sample](https://github.com/Samsung/TizenRT/tree/master/apps/examples/task_manager_sample) covers all of above mentioned functionality. Please find sample's details on [README](....../README.md).


README link is not working.

seinfra · 2018-06-24T23:42:26Z

Target : [ac952e19c85daffc143d44e0d56fc8cf2d69299e] - Code Rule Check (C++) OK.

seinfra · 2018-06-24T23:42:27Z

Target : [ac952e19c85daffc143d44e0d56fc8cf2d69299e] - Code Rule Check OK.

…der file 1. Add basic description in README.md 2. Modify wrong expression and add description in task_manager.h

seinfra · 2018-06-25T07:17:20Z

Target : [3584c45] - Code Rule Check OK.

seinfra · 2018-06-25T07:17:32Z

Target : [3584c45] - Code Rule Check (C++) OK.

sunghan-chang reviewed Jun 14, 2018

View reviewed changes

jeongchanKim force-pushed the tm_readme branch from a970745 to c31555a Compare June 14, 2018 02:11

jeongchanKim force-pushed the tm_readme branch 2 times, most recently from dc483f3 to 8c4a08d Compare June 14, 2018 02:24

jeongchanKim force-pushed the tm_readme branch 3 times, most recently from cfd12b7 to e2fb86d Compare June 14, 2018 04:35

jeongchanKim force-pushed the tm_readme branch from e2fb86d to 0de0d07 Compare June 14, 2018 04:41

jeongchanKim force-pushed the tm_readme branch 2 times, most recently from ed05831 to 5b25be2 Compare June 14, 2018 04:55

jeongarmy approved these changes Jun 14, 2018

View reviewed changes

sunghan-chang reviewed Jun 15, 2018

View reviewed changes

jeongchanKim force-pushed the tm_readme branch from 6118586 to 69f3234 Compare June 17, 2018 22:47

jeongchanKim force-pushed the tm_readme branch from 69f3234 to bd8faf7 Compare June 17, 2018 22:59

jeongchanKim force-pushed the tm_readme branch 2 times, most recently from 775cc88 to 8802883 Compare June 18, 2018 08:21

jeongchanKim force-pushed the tm_readme branch 3 times, most recently from 5780669 to 5d19f8f Compare June 21, 2018 06:36

sunghan-chang requested changes Jun 22, 2018

View reviewed changes

jeongchanKim force-pushed the tm_readme branch from 5d19f8f to ac952e1 Compare June 24, 2018 23:36

framework/task_manager : Add README and modify the description in hea…

3584c45

…der file 1. Add basic description in README.md 2. Modify wrong expression and add description in task_manager.h

jeongchanKim force-pushed the tm_readme branch from ac952e1 to 3584c45 Compare June 25, 2018 07:11

sunghan-chang approved these changes Jun 27, 2018

View reviewed changes

sunghan-chang merged commit add1da9 into Samsung:master Jun 27, 2018

jeongchanKim deleted the tm_readme branch July 5, 2018 22:56

Features	Functions
Regitration	task_manger_register()
	task_manager_unregister()
------------	-------------------------------

		Builtin information should follow the [format](https://github.com/Samsung/TizenRT/tree/master/apps/builtin).


		Further details are shown below.



		## Sample Application
		[Task Manager Sample](https://github.com/Samsung/TizenRT/tree/master/apps/examples/task_manager_sample) covers all of above mentioned functionality. Please find sample's details on [README](....../README.md).

framework/task_manager : Add README and modify the description in he… #1864

framework/task_manager : Add README and modify the description in he… #1864

Conversation

jeongchanKim commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

jeongarmy commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

seinfra commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seinfra commented Jun 17, 2018

seinfra commented Jun 17, 2018

seinfra commented Jun 17, 2018

seinfra commented Jun 17, 2018

seinfra commented Jun 18, 2018

seinfra commented Jun 18, 2018

seinfra commented Jun 21, 2018

seinfra commented Jun 21, 2018

seinfra commented Jun 21, 2018

seinfra commented Jun 21, 2018

Choose a reason for hiding this comment

seinfra commented Jun 24, 2018

seinfra commented Jun 24, 2018

seinfra commented Jun 25, 2018

seinfra commented Jun 25, 2018