Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artik audio bootup #545

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Fix artik audio bootup #545

merged 1 commit into from
Sep 7, 2017

Conversation

btheosam
Copy link
Contributor

@btheosam btheosam commented Sep 7, 2017

No description provided.

@@ -126,14 +126,29 @@ static void board_gpio_initialize(void)
****************************************************************************/
static void board_i2c_initialize(void)
{
#ifdef CONFIG_I2C
#ifdef CONFIG_S5J_I2C
#if defined CONFIG_I2C && defined CONFIG_S5J_I2C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use brackets.

#if defined(CONFIGXX) && defined(CONFIG_YY)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -0,0 +1,341 @@
/****************************************************************************
*
* Copyright 2016 Samsung Electronics All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016 -> 2017

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

/* Get an instance of the I2S interface for the ALC5658 data channel */

i2s = s5j_i2s_initialize();
if (!i2s) {
Copy link
Contributor

@shivgarg shivgarg Sep 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be called with 0 as argument, 0 indicating the i2s port.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Taejun-Kwon Taejun-Kwon merged commit 3f599c2 into Samsung:master Sep 7, 2017
@btheosam btheosam deleted the audiofix branch September 7, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants