-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel testcases #6177
Add kernel testcases #6177
Conversation
…of kernel module testcases
tc_environ_setenv_getenv_unsetenv_pos(); | ||
tc_environ_getenv_neg(); | ||
tc_environ_setenv_name_null_neg(); | ||
tc_environ_setenv_empty_name_neg(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't check the TizenRT commit rules. Could you check that at the wiki?
@@ -45,7 +45,7 @@ | |||
* Preconditions :none | |||
* Postconditions :none | |||
*/ | |||
static void itc_environ_setenv_p(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check _p
and _n
internally in the automation tool. Do you have any reason to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check
_p
and_n
internally in the automation tool. Do you have any reason to change?
In some functions the _p and _n are at the middle and others are at the end of the function name, this is not identified properly in the TCM tool. So, I have changed the names as _pos and _neg at the end of the function for better identification and uniformity.
@@ -62,6 +62,6 @@ static void itc_libc_semaphore_getprotocol_n_no_sem_init(void) | |||
|
|||
int itc_libc_semaphore_main(void) | |||
{ | |||
itc_libc_semaphore_getprotocol_n_no_sem_init(); | |||
itc_libc_semaphore_getprotocol_no_sem_init_neg(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as previous
u/itc_module_feature_function_n/p_details
This is what we use in the naming and automation tool parses.
Please let me know why you change the naming.
tc_clock_clock_get_time_pos(); | ||
tc_clock_clock_set_time_pos(); | ||
tc_clock_clock_set_time_neg(); | ||
tc_clock_clock_getres_pos(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check indentation
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep just 1 empty line for separating.
The kernel testcases are modified to segregate it a positive and negative.