Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/board/rtl8730e: add API to return BLE indication queue count #6193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

os/board/rtl8730e: add API to return BLE indication queue count #6193

wants to merge 1 commit into from

Conversation

yeetee179
Copy link
Contributor

  • add ble_server_get_indicate_pending_count API that returns current indication queue count to application

kishore-sn
kishore-sn reviewed May 27, 2024
View reviewed changes
framework/src/ble_manager/ble_manager_event.h Outdated
@@ -62,6 +62,7 @@ typedef enum {
BLE_CMD_GET_PROFILE_COUNT,
BLE_CMD_CHARACT_NOTI,
BLE_CMD_CHARACT_INDI,
BLE_CMD_GET_INDICATE_PENDDING_CNT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PENDDING -> PENDING

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified as suggested

framework/src/ble_manager/ble_manager_api.c
@@ -343,6 +343,15 @@ ble_result_e ble_server_charact_indicate(ble_attr_handle attr_handle, ble_conn_h
RETURN_RESULT(res, msg);
}

ble_result_e ble_server_get_indicate_pending_count(ble_conn_handle con_handle, uint8_t *count)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls perform NULL check for count before using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a NULL for count

@yeetee179 yeetee179 force-pushed the AIDual_return_indication_queue_full branch 3 times, most recently from 5860646 to 7c5cbef Compare May 27, 2024 05:29
@yeetee179
os/board/rtl8730e: add API to return BLE indication queue count
aabff75 
- add ble_server_get_indicate_pending_count API that returns current indication queue count to application
@yeetee179 yeetee179 force-pushed the AIDual_return_indication_queue_full branch from 7c5cbef to aabff75 Compare May 27, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore-sn kishore-sn kishore-sn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yeetee179 @kishore-sn