-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/board/rtl8730e: add API to return BLE indication queue count #6193
os/board/rtl8730e: add API to return BLE indication queue count #6193
Conversation
yeetee179
commented
May 23, 2024
- add ble_server_get_indicate_pending_count API that returns current indication queue count to application
@@ -62,6 +62,7 @@ typedef enum { | |||
BLE_CMD_GET_PROFILE_COUNT, | |||
BLE_CMD_CHARACT_NOTI, | |||
BLE_CMD_CHARACT_INDI, | |||
BLE_CMD_GET_INDICATE_PENDDING_CNT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PENDDING -> PENDING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified as suggested
@@ -343,6 +343,15 @@ ble_result_e ble_server_charact_indicate(ble_attr_handle attr_handle, ble_conn_h | |||
RETURN_RESULT(res, msg); | |||
} | |||
|
|||
ble_result_e ble_server_get_indicate_pending_count(ble_conn_handle con_handle, uint8_t *count) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls perform NULL check for count
before using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a NULL for count
5860646
to
7c5cbef
Compare
- add ble_server_get_indicate_pending_count API that returns current indication queue count to application
7c5cbef
to
aabff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have confirmed that it works on the product code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM we tested.