-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/board/rtl8730e&rtl8721csm: Support CMSIS #6196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split the commit as 3 commits
- add cmsis in the external (including removing from os)
- add example in the apps
- adjust defconfig for cmsis
apps/examples/board_specific_demo/ameba_cmsis_dsp_demo/example_cmsis_dsp.c
Outdated
Show resolved
Hide resolved
ece7f17
to
7691e2c
Compare
In our side, we checked performance became better. How about your side? |
Hi @Taejun-Kwon , May i know if you tested on loadable app config also ? So, Zhenbei asked how to resolve it . |
We tested loadable configuration with cmsis_nn, it was working fine. Now I see @sunghan-chang has suggested not to change os/*.mk files. So we will check the compilation again and share result with you. |
Hello @ZhenBei-Sin, |
7691e2c
to
a95fda3
Compare
Hi @aadotverma , Thank you for assist to archive cmsis lib into libexternal.a for loadable_apps. I updated the latest lib_cmsis_dsp.a, which solved the multiple definition error. |
Solved the link lib for loadable_apps. |
Change Notes: - Port CMSIS-DSP for rtl8721csm https://github.com/ARM-software/CMSIS-DSP/tree/v1.15.0 os/arch/arm/include/amebad/cmsis_dsp/* - Add the CMSIS-DSP and CMSIS-NN lib to external folder external/cmsis_dsp/* external/cmsis_nn/* - Delete the previous located CMSIS lib from the os folder os/arch/arm/src/*/Make.defs os/arch/arm/src/*/Kconfig os/board/*/src/libs/*
Change Notes: - Add CMSIS-DSP example for rtl8721csm apps/examples/board_specific_demo/ameba_cmsis_dsp_demo/* - Standard Code Formatting and clean up the naming apps/examples/board_specific_demo/ameba_cmsis_nn_demo/example_cmsis_nn.c apps/examples/board_specific_demo/ameba_cmsis_nn_demo/Makefile
rtl8730e: Support CMSIS-NN rtl8721csm: Support CMSIS-NN and CMSIS-DSP Change Notes: - Modify the config for the CMSIS macro CONFIG_AMEBAx_CMSIS_NN -> CONFIG_EXTERNAL_CMSIS_NN CONFIG_EXTERNAL_CMSIS_DSP
a95fda3
to
6f71d50
Compare
Hi @sunghan-chang , @Taejun-Kwon , @vibhor-m , @aadotverma Please help to review the final changes. |
external/cmsis: Add CMSIS in the external
Change Notes:
Port CMSIS-DSP for rtl8721csm https://github.com/ARM-software/CMSIS-DSP/tree/v1.15.0
os/arch/arm/include/amebad/cmsis_dsp/*
Add the CMSIS-DSP and CMSIS-NN lib to external folder
external/cmsis_dsp/*
external/cmsis_nn/*
Delete the previous located CMSIS lib from the os folder
os/arch/arm/src//Make.defs
os/arch/arm/src//Kconfig
os/board//src/libs/
apps/examples/board_specific_demo: Add CMSIS example
Change Notes:
Add CMSIS-DSP example for rtl8721csm
apps/examples/board_specific_demo/ameba_cmsis_dsp_demo/*
Standard Code Formatting and clean up the naming
apps/examples/board_specific_demo/ameba_cmsis_nn_demo/example_cmsis_nn.c
apps/examples/board_specific_demo/ameba_cmsis_nn_demo/Makefile
build/configs/rtl8730e&rtl8721csm: Adjust defconfig for CMSIS
rtl8730e: Support CMSIS-NN
rtl8721csm: Support CMSIS-NN and CMSIS-DSP
Change Notes:
CONFIG_AMEBAx_CMSIS_NN -> CONFIG_EXTERNAL_CMSIS_NN
CONFIG_EXTERNAL_CMSIS_DSP