feat(configuration_support): change conditional branch steps type to … #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some update the docker engine started to require passing full paths to bind mounts when starting the contianer. The issue is reproduced on version 23.0.2. The error message from the docker engine is the following: "invalid volume specification: '.work:.work:rw': invalid mount config for type "volume": invalid mount path: '.work' mount path must be absolute".
Before fix: $ python3.10 -m universum.analyzers.mypy --help usage: mypy.py [-h] ... After fix: $ python3.10 -m universum.analyzers.mypy --help usage: python3.10 -m universum.analyzers.mypy [-h] ...
Partially reverted the last change to allow Sphinx argparse extension to work.
Replaced test of truthiness with an explicit check of None value Resolves #764 Tested by doctests
Static_analysis_report.json is not used for core report functionality, but is added to artifacts and creates misleading assumption that it has some deeper meaning.
Common code for clang_format and uncrustify analyzers is placed to utils. Also fixed some error messages of analyzers, fixed a test failure due to another docker engine update and added doc string for one unclear test.
All previews refer to Universum main page anyway.
21 tasks
i-keliukh
reviewed
May 5, 2023
| @@ -182,8 +182,8 @@ def __init__(self, | |||
| pass_tag: str = '', | |||
| fail_tag: str = '', | |||
| if_env_set: str = '', | |||
| if_succeeded = None, | |||
| if_failed = None, | |||
| if_succeeded: Optional['Configuration'] = None, | |||
There was a problem hiding this comment.
Please also update documentation
i-keliukh
reviewed
May 5, 2023
i-keliukh
reviewed
May 5, 2023
None is no longer supported as default language for RTD Fix typo in 'clang-format' module name
Latest selenium version is 4.0.9; latest urllib3 version is 2.0.2. However, used selenium version is 3.141, and latest non-failing urllib3 version for running FF with this selenium version is 1.26.15
…um into cs_step_to_configuration
|
Changes were applied in the #808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing one of the previous PR comments - #737 (comment).
Tests extension will be prepared in a separate PR.