Support Symbol type in WeakMap, WeakSet, WeakRef and FinalizationRegistry #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
ksh8281
reviewed
Jan 12, 2024
src/api/EscargotPublic.cpp
Outdated
| @@ -4265,19 +4265,28 @@ WeakSetObjectRef* WeakSetObjectRef::create(ExecutionStateRef* state) | |||
| return toRef(new WeakSetObject(*toImpl(state))); | |||
| } | |||
|
|
|||
| void WeakSetObjectRef::add(ExecutionStateRef* state, ObjectRef* key) | |||
| void WeakSetObjectRef::add(ExecutionStateRef* state, ValueRef* key) | |||
There was a problem hiding this comment.
If value is not Heldable, how about return false?
There was a problem hiding this comment.
I fixed it to return boolean as you commented
Thanks for the review!
Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
ksh8281
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.