Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing arbitrary key value pair in the request's URL #9

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

AlexisPrelAER
Copy link
Contributor

This pull request makes a few minor changes to expose a new optional keyword argument when invoking get_data or get_multiple_series. This shows up in the URL as key=value pairs.

Example usage:

  1. specify that you want hourly data
    esios.get_data(indicator, start_date, end_date, groupby='hour')

  2. specify that you want data for a specific province
    esios.get_data(indicator, start_date, end_date, geo_id=22)

@SanPen
Copy link
Owner

SanPen commented Oct 3, 2023

@JotaFan could you please review this?
It is failing the linter check

@JotaFan
Copy link
Collaborator

JotaFan commented Oct 3, 2023

Run:

make init-dev
make lint-fix

and then commit the changes, it should pass then.
Otherwise you can merge, it is just linting

@JotaFan
Copy link
Collaborator

JotaFan commented Oct 3, 2023

@AlexisPrelAER if you can run those commands on your local code, and commit after the changes, then it should be fine

@JotaFan JotaFan merged commit bbef64d into SanPen:master Oct 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants