Use cookie auth if requesting the manifest fails with token auth #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some content like Amazon Freevee is not available when using token auth. By allowing to use cookie auth if token auth does not work, it will be possible to play that content without degrading the quality of anything that is available with token auth.
|
This successfully fixed #640 https://github.com/Sandmann79/xbmc/blob/master/plugin.video.amazon-test/resources/lib/network.py#L278 |
|
Thanks for the quick Freevee fix for Android...StollD...this one works well for me. |
|
I thought I had already merged this when I released 0.9.6, I didn't even test it ç_ç |
4 tasks
|
Thank you for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some content, like Amazon Freevee, is not available when using token auth. By allowing to use cookie auth if token auth does not work, it will be possible to play that content without degrading the quality of anything that is available with token auth.
Admittedly, just stuffing the code into a loop that iterates over
[True, False]is a bit of a hack, but it seemed cleaner that just putting the code there a second time. I would have prefered a method, but given that the return values from_getPlaybackVarsare used later, this could have become a bit messy. In a loop they will just "leak" to the outside, because of python.