Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display version number in settings #34

Merged
merged 5 commits into from
Sep 30, 2023
Merged

Display version number in settings #34

merged 5 commits into from
Sep 30, 2023

Conversation

micedreams
Copy link
Collaborator

@micedreams micedreams commented Sep 29, 2023 •
edited

Screenshot 2023-09-29 at 18 58 45 Screenshot 2023-09-29 at 18 59 00

@micedreams micedreams linked an issue Sep 29, 2023 that may be closed by this pull request
Display version number in settings #14
Closed
@micedreams micedreams closed this Sep 29, 2023
@micedreams micedreams reopened this Sep 30, 2023
@micedreams micedreams added the hacktoberfest Applicable to hacktoberfest label Sep 30, 2023
SankethBK
SankethBK reviewed Sep 30, 2023
View reviewed changes
Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, rest all looks good!

lib/features/auth/presentation/bloc/cubit/version_number_cubit.dart Outdated
final info = await PackageInfo.fromPlatform();
emit(info.version);
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new cubit is not necessary as we don't have any dynamic properties in the state. Also, we can't update the version number dynamically in Flutter. So It's fine to call PackageInfo.fromPlatform(); directly in the VersionNumber widget.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SankethBK I did not see Future Builder being used anywhere... that's why I created a cubit. Can I use a Future builder? or should I use something else?!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey again... I went ahead and used Future builder.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey FutureBuilder is fine

@micedreams micedreams merged commit cd3c2d9 into master Sep 30, 2023
1 check passed
@SankethBK
Copy link
Owner

Thank you again for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SankethBK SankethBK SankethBK approved these changes

Assignees
No one assigned
Labels
hacktoberfest Applicable to hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display version number in settings
2 participants
@micedreams @SankethBK