Skip to content

Commit

Permalink
Bump version to 0.0.4
Browse files Browse the repository at this point in the history
Change some lines to decrease cpplint warnings
  • Loading branch information
Sannis committed Mar 31, 2010
1 parent 2212248 commit a4a962c
Show file tree
Hide file tree
Showing 6 changed files with 49 additions and 29 deletions.
29 changes: 28 additions & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,30 @@
= Version 0.0.4
* Split source code into separate files for database connection,
query result and prepared statements
* Add nodeunit as the test framework for project
* Implemented methods:
* * MysqlSyncConn::autoCommit()
* * MysqlSyncConn::commit()
* * MysqlSyncConn::debug()
* * MysqlSyncConn::dumpDebugInfo()
* * MysqlSyncConn::fieldCount()
* * MysqlSyncConn::getInfoString()
* * MysqlSyncConn::getWarnings()
* * MysqlSyncConn::initStmt()
* * MysqlSyncConn::multiMoreResults()
* * MysqlSyncConn::multiNextResult()
* * MysqlSyncConn::multiRealQuery()
* * MysqlSyncConn::realQuery()
* * MysqlSyncConn::rollback()
* * MysqlSyncConn::stat()
* * MysqlSyncConn::storeResult()
* * MysqlSyncConn::threadId()
* * MysqlSyncConn::threadKill()
* * MysqlSyncConn::threadSafe()
* * MysqlSyncConn::useResult()
* * MysqlSyncStmt::prepare()
* Decrease number of cpplint warnings (dirty hack? maybe)

= Version 0.0.3
* Add 'lint' target for node-waf
* Add docs dir, docs/examples.md,
Expand All @@ -13,7 +40,7 @@
* * MysqlSyncConn::SelectDb()
* * MysqlSyncConn::SetCharset()
* * MysqlSyncConn::SetSsl()
* Improve MysqlSyncConn::Connect() functionality, see d2d9ae207daa704618e205fc18d464220de7879b
* Improve MysqlSyncConn::Connect() functionality, see d2d9ae2

= Version 0.0.2
* Split MysqlDbSync into MysqlSyncConn and MysqlSyncRes
Expand Down
19 changes: 9 additions & 10 deletions mysql_bindings_connection.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Copyright (C) 2010, Oleg Efimov <efimovov@gmail.com>
See license text in LICENSE file
*/

#ifndef NODE_MYSQL_CONNECTION_H
#ifndef NODE_MYSQL_CONNECTION_H // NOLINT
#define NODE_MYSQL_CONNECTION_H

#include <mysql/mysql.h>
Expand Down Expand Up @@ -41,10 +41,7 @@ Local<External> VAR = Local<External>::Cast(args[I]);
conn->multi_query = true; \
}

// This line caused
// "Do not use namespace using-directives. Use using-declarations instead."
// [build/namespaces] [5] error in cpplint.py
using namespace v8;
using namespace v8; // NOLINT

// static Persistent<String> affectedRows_symbol;
// static Persistent<String> autoCommit_symbol;
Expand Down Expand Up @@ -96,9 +93,9 @@ class MysqlSyncConn : public node::EventEmitter {
const char *host_info;
uint32_t proto_info;
};

class MysqlSyncRes;

class MysqlSyncStmt;

static void Init(Handle<Object> target);
Expand Down Expand Up @@ -207,10 +204,12 @@ class MysqlSyncConn : public node::EventEmitter {
static Handle<Value> WarningCount(const Arguments& args);
};

//Persistent<FunctionTemplate> MysqlSyncConn::MysqlSyncRes::constructor_template;
//Persistent<FunctionTemplate> MysqlSyncConn::MysqlSyncStmt::constructor_template;
// Persistent<FunctionTemplate> MysqlSyncConn::
// MysqlSyncRes::constructor_template;
// Persistent<FunctionTemplate> MysqlSyncConn::
// MysqlSyncStmt::constructor_template;

extern "C" void init(Handle<Object> target);

#endif // NODE_MYSQL_CONNECTION_H
#endif // NODE_MYSQL_CONNECTION_H // NOLINT

9 changes: 2 additions & 7 deletions mysql_bindings_result.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Copyright (C) 2010, Oleg Efimov <efimovov@gmail.com>
See license text in LICENSE file
*/

#ifndef NODE_MYSQL_RESULT_H
#ifndef NODE_MYSQL_RESULT_H // NOLINT
#define NODE_MYSQL_RESULT_H

#include <mysql/mysql.h>
Expand All @@ -13,11 +13,6 @@ See license text in LICENSE file
#include <node.h>
#include <node_events.h>

// This line caused
// "Do not use namespace using-directives. Use using-declarations instead."
// [build/namespaces] [5] error in cpplint.py
using namespace v8;

// static Persistent<String> fetchResult_symbol;

class MysqlSyncConn::MysqlSyncRes : public EventEmitter {
Expand All @@ -41,5 +36,5 @@ class MysqlSyncConn::MysqlSyncRes : public EventEmitter {
static Handle<Value> FetchResult(const Arguments& args);
};

#endif // NODE_MYSQL_RESULT_H
#endif // NODE_MYSQL_RESULT_H // NOLINT

9 changes: 2 additions & 7 deletions mysql_bindings_statement.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Copyright (C) 2010, Oleg Efimov <efimovov@gmail.com>
See license text in LICENSE file
*/

#ifndef NODE_MYSQL_STATEMENT_H
#ifndef NODE_MYSQL_STATEMENT_H // NOLINT
#define NODE_MYSQL_STATEMENT_H

#include <mysql/mysql.h>
Expand All @@ -13,11 +13,6 @@ See license text in LICENSE file
#include <node.h>
#include <node_events.h>

// This line caused
// "Do not use namespace using-directives. Use using-declarations instead."
// [build/namespaces] [5] error in cpplint.py
using namespace v8;

// static Persistent<String> prepare_symbol;

class MysqlSyncConn::MysqlSyncStmt : public EventEmitter {
Expand All @@ -41,5 +36,5 @@ class MysqlSyncConn::MysqlSyncStmt : public EventEmitter {
static Handle<Value> Prepare(const Arguments& args);
};

#endif // NODE_MYSQL_STATEMENT_H
#endif // NODE_MYSQL_STATEMENT_H // NOLINT

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name" : "node-mysql-sync",
"description" : "MySQL synchronous binding for Node.js",
"version" : "0.0.3",
"version" : "0.0.4",
"author" : "Oleg Efimov <efimovov@gmail.com>"
}
10 changes: 7 additions & 3 deletions wscript
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ from os.path import exists

srcdir = "."
blddir = "build"
VERSION = "0.0.3"
VERSION = "0.0.4"

def set_options(opt):
opt.tool_options("compiler_cxx")
Expand All @@ -28,8 +28,12 @@ def test(tst):
Utils.exec_command('./tests/run-tests.sh')

def lint(lnt):
Utils.exec_command('cpplint ./mysql_conn_bindings.cc')
Utils.exec_command('cpplint ./mysql_conn_bindings.h')
Utils.exec_command('cpplint ./mysql_bindings_connection.cc')
Utils.exec_command('cpplint ./mysql_bindings_connection.h')
Utils.exec_command('cpplint ./mysql_bindings_result.cc')
Utils.exec_command('cpplint ./mysql_bindings_result.h')
Utils.exec_command('cpplint ./mysql_bindings_statement.cc')
Utils.exec_command('cpplint ./mysql_bindings_statement.h')
Utils.exec_command('nodelint ./mysql-sync.js')
Utils.exec_command('nodelint ./tests/settings.js')
Utils.exec_command('nodelint ./tests/test-*.js')
Expand Down

0 comments on commit a4a962c

Please sign in to comment.