Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgurfetcher doesn't do well with albums. #3

Closed
ElDeveloper opened this issue Apr 7, 2015 · 2 comments · Fixed by #4
Closed

imgurfetcher doesn't do well with albums. #3

ElDeveloper opened this issue Apr 7, 2015 · 2 comments · Fixed by #4
Labels

Comments

@ElDeveloper
Copy link
Collaborator

I tried changing the name of the subreddit to spaceporn and the following exception showed up:

yoshikivazquezbaeza:~$ background_daemon.py 
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/bin/background_daemon.py", line 4, in <module>
    __import__('pkg_resources').run_script('bg-daemon==0.0.1', 'background_daemon.py')
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources.py", line 517, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources.py", line 1443, in run_script
    exec(script_code, namespace, namespace)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bg_daemon-0.0.1-py2.7.egg/EGG-INFO/scripts/background_daemon.py", line 240, in <module>

  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bg_daemon-0.0.1-py2.7.egg/EGG-INFO/scripts/background_daemon.py", line 196, in poll

  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/bg_daemon-0.0.1-py2.7.egg/EGG-INFO/scripts/background_daemon.py", line 128, in update

  File "build/bdist.macosx-10.6-intel/egg/bg_daemon/fetchers/imgurfetcher.py", line 131, in query
  File "build/bdist.macosx-10.6-intel/egg/bg_daemon/fetchers/imgurfetcher.py", line 233, in _select_image
AttributeError: GalleryAlbum instance has no attribute 'width'

This may be a shot in the dark, but I think fetcher needs to verify that it is indeed looking at an image not an album.

@ElDeveloper ElDeveloper added the bug label Apr 7, 2015
@SantiagoTorres
Copy link
Owner

Hmmm, I wouldn't be surprised if this was true. Do you have the address of the gallery so I can repeat the bug?

@ElDeveloper
Copy link
Collaborator Author

No, I don't have the URL handy, from looking at the log file it doesn't
seem like it saved that information. I'm sure you can try with any
album.

On (Apr-07-15| 7:01), Santiago Torres wrote:

Hmmm, I wouldn't be surprised if this was true. Do you have the address of the gallery so I can repeat the bug?


Reply to this email directly or view it on GitHub:
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants