ENH: Add quack compilation to setup.py

[ElDeveloper]

If a C compiler and Make are available, quack will be compiled and
installed when running setup.py, otherwise the mac-update.sh script will
fall-back to using osascript.

[ElDeveloper]

BTW, I'm all for making any changes to main.m, your C-fu is much more powerful than mine.

[SantiagoTorres]

Wow this is great, thanks @ElDeveloper !

I'm wondering if instead of keeping the automator script we could:

• change to your other alternative.
• Pre-compile and host the binary elsewhere....

What do you think?

[ElDeveloper]

Hmmm, what about 1) tries to compile, 2) tries to download binary and 3)
falls back to the applescript. If we decide to go with this we are gonna
need to find a way to host the binary and compile it to keep it up to
date every time main.m changes.

On (Apr-03-15| 9:37), Santiago Torres wrote:

Wow this is great, thanks @ElDeveloper !

I'm wondering if instead of keeping the automator script we could:

• change to your other alternative.
• Pre-compile and host the binary elsewhere....

What do you think?

---

Reply to this email directly or view it on GitHub:
#1 (comment)

[SantiagoTorres]

^ This would make sense 👍

Hosting the binary somewhere doesn't seem that much of a challenge. I'm thinking of a git hook on the server side and finding a way to compile OSX binaries.

In the meantime we can get 1 and 3 to integrate this into the codebase ASAP and move 2) to a ticket.

[ElDeveloper]

Ok, I've opened #2

[SantiagoTorres]

I'm wondering if test ([) is a better command for this.

if [ -e quack ]
then
   ....

[ElDeveloper]

Don't think so:

yoshikivazquezbaeza:~$ ls quack
ls: quack: No such file or directory
yoshikivazquezbaeza:~$ which quack
/Library/Frameworks/Python.framework/Versions/2.7/bin/quack
yoshikivazquezbaeza:~$ if [ -e quack ]; then echo "plel"; else echo "lolercoaster"; fi
lolercoaster

[SantiagoTorres]

In general it looks in good shape. My last comment is that mac-update.sh could be "deprecated" in the long run. We could instead change to quack as the definitive manager for the image and update it at configuration time by setting the update hook to be "quack -i {target}.

[ElDeveloper]

Ready for another round.

[SantiagoTorres]

I'm still not completely convinced about this, it is not self-explanatory:

• Why quack -h?
• Are we testing that quack exists or that it runs successfully?

I'd rather go with an alternative that is self descriptive here:

if [-e $(which quack)] 
...

or

if which quack

For that matter.

[SantiagoTorres]

@ElDeveloper Guess that's all 💯

[ElDeveloper]

Thanks!

On (Apr-05-15|20:17), Santiago Torres wrote:

@ElDeveloper Guess that's all 💯

---

Reply to this email directly or view it on GitHub:
#1 (comment)