Fixes the old imgurpython issue #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElDeveloper
requested changes
May 30, 2017
src/info.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"description": null, "author": "N/A", "section": "EarthPorn", "views": 1351, "link": "http://i.imgur.com/NVoTiPC.jpg", "title": "Trinity Alps, CA "} | |||
There was a problem hiding this comment.
Can you remove this file?
The title string as obtained from the imgur library doesn't encode characters in either ascii or utf-8, but provides a Unicode object (which I never seem to understand). This causes a crash when trying to log a title that contains extraneous characters (as it can be seen with the multiplication sign under https://imgur.com/6KswIQG). We force UTF-8 encoding on the title string to avoid this issue.
The old imgur library didn't work anymore, and the logger messages we had were pretty unclear/confusing. Update the api calls and the logger format strings to fix this.
SantiagoTorres
force-pushed
the
update-imgurapi
branch
from
e8e444f
to
7f66e36
Compare
ElDeveloper
approved these changes
Jun 7, 2017
|
Thanks @SantiagoTorres! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.