Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a contact page #187

Merged
merged 17 commits into from
Dec 10, 2022
Merged

Adding a contact page #187

merged 17 commits into from
Dec 10, 2022

Conversation

IM-TECHNO
Copy link
Contributor

Added Contact page #186

@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit a871b36
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/63948e19b34e1e000911d506
😎 Deploy Preview https://deploy-preview-187--drifty.netlify.app/contact
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IM-TECHNO IM-TECHNO changed the title Create contact.html Adding a contact page Oct 31, 2022
@IM-TECHNO
Copy link
Contributor Author

Kindly Review @SaptarshiSarkar12

@IM-TECHNO
Copy link
Contributor Author

Hello, Can you review ? @SaptarshiSarkar12

SaptarshiSarkar12
SaptarshiSarkar12 requested changes Nov 1, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IM-TECHNO Please fix this bug.
Bug Description - When I enter only some inputs and some required inputs are missing, still the website shows Thank you... . It should have shown this is a required field like in the second pic.

image
image

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Nov 1, 2022 that may be closed by this pull request
Adding a Contact Page for the website #186
Closed
@IM-TECHNO
Copy link
Contributor Author

Working on it @SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

Working on it @SaptarshiSarkar12

How much is done @IM-TECHNO ?

@SaptarshiSarkar12
Copy link
Owner

Working on it @SaptarshiSarkar12

How much is done @IM-TECHNO ?

@IM-TECHNO Please respond.

@IM-TECHNO
Copy link
Contributor Author

i'm Working on it currently. I was busy for the past 2 days. Will Complete soon

@SaptarshiSarkar12
Copy link
Owner

i'm Working on it currently. I was busy for the past 2 days. Will Complete soon

Ok, you may complete your work once you are free.

@IM-TECHNO
Copy link
Contributor Author

Hello, I've been very busy lately and I apologize for the delay. I have disabled the message but made a workaround. I will update today.

@IM-TECHNO
Update contact.html
8a0efce
@IM-TECHNO
Create thanks.html
9c96c35 
Added Thanks.html as an workaround
@IM-TECHNO
Copy link
Contributor Author

To test thanks.html, you might need to download the file as netlify doesn't change the internal URLs provided.

@IM-TECHNO
Copy link
Contributor Author

@SaptarshiSarkar12 Kindly check when you're free.

@IM-TECHNO
Copy link
Contributor Author

IM-TECHNO commented Nov 18, 2022 •
edited

image
This change does not work when pushed to the web-server. I have tested it. This is because the _next value needs an URL and not a path. It is mentioned in its documentation.

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Please make the button background colour and We'd love to hear from you text colour more distinct and prominent in light mode.
image

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Please make the button background colour and We'd love to hear from you text colour more distinct and prominent in light mode. image

Please make the above suggested changes and let me know when you are done. @IM-TECHNO I shall review it then.

@SaptarshiSarkar12
Copy link
Owner

@IM-TECHNO Have you completed the work?

@IM-TECHNO
Merge branch 'SaptarshiSarkar12:master' into patch-2
229f5ef
@IM-TECHNO
Update contact.css
5b9b64e 
Changes made according to new changes
@IM-TECHNO
Update contact.html
a871b36 
Changes made according to requirement
@IM-TECHNO
Copy link
Contributor Author

I apologize for the long delay. I wasn't well in these few days. Covid never really leaves us lol. I have completed the asked works, kindly check and update.

@SaptarshiSarkar12
Copy link
Owner

I apologize for the long delay. I wasn't well in these few days. Covid never really leaves us lol. I have completed the asked works, kindly check and update.

It's okay, get well soon and take some rest as well. I have checked your latest commits, everything seems fine. Shall review it shortly.

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Dec 10, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge 👍 Thanks for contributing 🚀 🚀 🚀

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 31f8ce2 into SaptarshiSarkar12:master Dec 10, 2022
@IM-TECHNO
Copy link
Contributor Author

I should thank you for not closing this issue for inactivity. I really liked the idea of Drifty and I still want to contribute more to the FrontEnd side !. Cheers !

@SaptarshiSarkar12
Copy link
Owner

I should thank you for not closing this issue for inactivity. I really liked the idea of Drifty and I still want to contribute more to the FrontEnd side !. Cheers !

Thank you for your appreciation! I wait for every inactive contributors to respond before I take any important steps. Surely, you may work on other frontend ideas of this project as well. @IM-TECHNO

@IM-TECHNO
Copy link
Contributor Author

I will contribute more to Drifty ! Thanks ! ❤️

@SaptarshiSarkar12
Copy link
Owner

I will contribute more to Drifty ! Thanks ! ❤️

Welcome @IM-TECHNO

@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #187 from IM-TECHNO/patch-2
c6af9c7 
Adding a contact page
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #187 from IM-TECHNO/patch-2
c1af0aa 
Adding a contact page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a Contact Page for the website
2 participants
@IM-TECHNO @SaptarshiSarkar12