Skip to content

Commit

Permalink
stop removing completion results caching flag from parse options
Browse files Browse the repository at this point in the history
It seems to cause more harm than good.

Not sure to understand if there is any downside to this change,
hopefully time will tell.

Related issues:

- #326
- #332
  • Loading branch information
Sarcasm committed Sep 25, 2016
1 parent 55dff3c commit 4b63b80
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions server/src/TUManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ TUManager::TUManager()
parseTUOptions_ |= CXTranslationUnit_IncludeBriefCommentsInCodeCompletion;
#endif

// XXX: Completion results caching doesn't seem to work right, changes at the
// top of the file (i.e: new declarations) aren't detected and do not appear
// in completion results.
parseTUOptions_ &= ~CXTranslationUnit_CacheCompletionResults;

// XXX: A bug in old version of Clang (at least '3.1-8') caused the completion
// to fail on the standard library types when
// CXTranslationUnit_PrecompiledPreamble is used. We disable this option for
Expand Down

0 comments on commit 4b63b80

Please sign in to comment.