-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 5.0.5b1 #1970
Conversation
Note: we will need to adjust all these again for actual releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butlerpd I am fine with 5.0.5b1 but I am also thinking whether 5.0.5rc1 wouldn't be better? I guess it may be less confusing for users if we keep it with sync with tag v5.0.5rc1 (convention we used before) but if I recall correctly we use some module that stricly controls the names, so not sure if rc1 works. We can also change it to rc1 when we are ready with rc1 but sounds like overkill. Or should we switch to full 5.0.5 for rc1 release? Just some thoughts
Indeed, firstly we need to check what is allowed - but I believe rcx is acceptable in the strict versioning system. But secondly, we have no agreed standard procedure for this part of the release process, partly because this is somewhat new for us. Assuming rcx is allowed, I can see 3 options regarding versioning during the process though there are probably more. The three I thought of were:
Clearly, this PR assumes the 3rd option, but perhaps we should start with option 2? until we get on our feet and streamline the process better? |
Looking at PEP440 X.Y.Zax, X.Y.Z.bx, and X.Y.Z.rcx are respectively alpha pre-release, beta pre-release, and release candidate pre-release. Moreover they suggest .devx for "development" builds so X.Y.Z.dev1 for example could be used. Another possibility is to use + at the end for "local versioning" which presumably is more or less freeform so X.Y.Z+dev could also be used. Given this perhaps the proper approach would be to immediately upgrade the version in main after a final release to X.Y.Z.dev1, where X.Y.Z is the currently released version. Then when ready to make public releases we increment the release number and append a1, b1, or rc1 depending on the level of stability we expect (e.g. X.Y.Zrc1), and again immediately after that release we append .dev1 as in X.Y.Zrc1.dev1 as shown in PEP 440? |
Note: we will need to adjust all these again for actual releases.