Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the github workflows #1985

Merged
merged 20 commits into from
Dec 3, 2021
Merged

Conversation

wpotrzebowski
Copy link
Contributor

@wpotrzebowski wpotrzebowski commented Dec 2, 2021

Fixing release branches (sasview release uses sasmodels 1.0.6 release branch). It currently uses fixed/harcoded branch name, which means that it will need to be updated manually. Likewise it clones bumps 0.8.1. Not sure if there is better mechanism to do this. Bumps can probably be pip installed, however I am not sure if documentation works then (we build bumps docs on the fly).

Pinning to mpl version 3.4.3.

@wpotrzebowski wpotrzebowski changed the base branch from main to release_5.0.5 December 2, 2021 15:29
rozyczko
rozyczko previously approved these changes Dec 3, 2021
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Mentioned issues can be dealt with later

.github/workflows/installers.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@wpotrzebowski wpotrzebowski merged commit da96db7 into release_5.0.5 Dec 3, 2021
@wpotrzebowski wpotrzebowski deleted the gh_actions_release branch December 3, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants