Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm fails to build on x86 #356

Closed
jku opened this issue Jul 10, 2017 · 3 comments
Closed

glm fails to build on x86 #356

jku opened this issue Jul 10, 2017 · 3 comments

Comments

@jku
Copy link
Contributor

jku commented Jul 10, 2017

This is the same issue as in #283:
func_common.inl:193:51: error: wrong number of template arguments (5, should be 6) struct compute_sign<T, P, vecType, false, Aligned>

That one was close with "it looks like you only support AMD64" -- if this is really true please close.

The issue comes up when building for x86. I've tested the upstream copy of that template and it works. I can provide a patch if you don't plan to update the copy of glm from upstream.

@SaschaWillems
Copy link
Owner

That one was close with "it looks like you only support AMD64" -- if this is really true please close.

No, that's not intentional. I want to support as many platforms as possible, so thx for bringing this up.
I'll check with a recent version of glm and update my repo to fix this.

SaschaWillems added a commit that referenced this issue Jul 15, 2017
@SaschaWillems
Copy link
Owner

I have replaced the local glm copy with a proper submodule (master). Can you check again? Works fine for me on x86, but only tested with Visual Studio on Win.

@jku
Copy link
Contributor Author

jku commented Jul 17, 2017

Looks good to me, builds fine on Yocto for qemux86. Thanks!

@jku jku closed this as completed Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants