Require and placeholder #197

Closed
HugoGiraudel opened this Issue Sep 3, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@HugoGiraudel
Member

HugoGiraudel commented Sep 3, 2014

We have a bug with placeholders when implicitly required.

When writing:

/**
 * @requires %placeholder
 */

We end up with (in the console):

Item <item> requires %placeholder from type function but this item doesn't exist.

Because of %, {placeholder} should be optional, exactly like $ and variables. Yet, it doesn't work.

A fix like this should probably be added.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Sep 4, 2014

Member

Excellent @pascalduez. Please make sure both master and develop get the fix, then bump the patch on master.

Member

HugoGiraudel commented Sep 4, 2014

Excellent @pascalduez. Please make sure both master and develop get the fix, then bump the patch on master.

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Sep 4, 2014

Member

Tests passed
Back-ported on master
Npm bumped & published

Member

pascalduez commented Sep 4, 2014

Tests passed
Back-ported on master
Npm bumped & published

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Sep 4, 2014

Member

You won the internet gold star. 🌟

Member

HugoGiraudel commented Sep 4, 2014

You won the internet gold star. 🌟

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Sep 4, 2014

Member

The copy/paster badge.

Member

pascalduez commented Sep 4, 2014

The copy/paster badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment