Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require and placeholder #197

Closed
KittyGiraudel opened this issue Sep 3, 2014 · 4 comments
Closed

Require and placeholder #197

KittyGiraudel opened this issue Sep 3, 2014 · 4 comments
Assignees
Labels

Comments

@KittyGiraudel
Copy link
Member

We have a bug with placeholders when implicitly required.

When writing:

/**
 * @requires %placeholder
 */

We end up with (in the console):

Item <item> requires %placeholder from type function but this item doesn't exist.

Because of %, {placeholder} should be optional, exactly like $ and variables. Yet, it doesn't work.

A fix like this should probably be added.

@KittyGiraudel
Copy link
Member Author

Excellent @pascalduez. Please make sure both master and develop get the fix, then bump the patch on master.

@pascalduez
Copy link
Member

Tests passed
Back-ported on master
Npm bumped & published

@KittyGiraudel
Copy link
Member Author

You won the internet gold star. 🌟

@pascalduez
Copy link
Member

The copy/paster badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants