Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel 6 migration #481

Merged
merged 3 commits into from
Feb 12, 2017
Merged

Babel 6 migration #481

merged 3 commits into from
Feb 12, 2017

Conversation

pascalduez
Copy link
Member

@pascalduez pascalduez commented Feb 11, 2017 •
edited
Loading

Unit tests <3

@pascalduez pascalduez changed the title WIP - Babel 6 migration Babel 6 migration Feb 11, 2017
@KittyGiraudel
Copy link
Member

Looks good. :)

KittyGiraudel
KittyGiraudel approved these changes Feb 11, 2017
View reviewed changes
.babelrc
"regenerator": true
}],
["babel-plugin-transform-builtin-extend", {
"globals": ["Error"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Member Author

@pascalduez pascalduez Feb 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change between Babel 5 and 6: babel/babel#3083

We probably shouldn't do that apparently.
https://github.com/SassDoc/sassdoc/blob/master/src/errors.js

@pascalduez
Copy link
Member Author

I downgraded the ESLint parser for now, so that the tests pass.

Next step: rework the linting!

@coveralls
Copy link

coveralls commented Feb 11, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 94.633% when pulling 189b3a7 on hotfix/babel-upgrade into 8aad8c1 on master.

@coveralls
Copy link

coveralls commented Feb 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 94.368% when pulling fc97e22 on hotfix/babel-upgrade into 8aad8c1 on master.

valeriangalliat
valeriangalliat approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@valeriangalliat valeriangalliat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@KittyGiraudel
Copy link
Member

Any particular reason why code coverage decreased?

@pascalduez
Copy link
Member Author

Any particular reason why code coverage decreased?

Switch to nyc, and the use of that babel plugin for Errors.
I tried to investigate how we can improve things, sourcemaps'n stuff, but the difference is just to small to care of it.
Also we may switch to Jest at some point, which will make things easier.

@coveralls
Copy link

coveralls commented Feb 12, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 94.368% when pulling 35492f3 on hotfix/babel-upgrade into 8aad8c1 on master.

@pascalduez pascalduez merged commit 149c4c9 into master Feb 12, 2017
@KittyGiraudel
Copy link
Member

🎉

@pascalduez
Copy link
Member Author

I'm trying to understand/update the dependencies warnings from the default-theme, and then I'll make a release. So that you will be able to merge the linting branch @hugogiraudel ;)

@pascalduez pascalduez deleted the hotfix/babel-upgrade branch February 12, 2017 17:22
@pascalduez pascalduez modified the milestone: 2.2 Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KittyGiraudel KittyGiraudel KittyGiraudel approved these changes

@valeriangalliat valeriangalliat valeriangalliat approved these changes

@FWeinb FWeinb Awaiting requested review from FWeinb

Assignees
No one assigned
Labels
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalduez @KittyGiraudel @coveralls @valeriangalliat