Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need tests for frontend_server #3152

Closed
2 of 3 tasks
benhammondmusic opened this issue Apr 16, 2024 · 0 comments · Fixed by #3297
Closed
2 of 3 tasks

Need tests for frontend_server #3152

benhammondmusic opened this issue Apr 16, 2024 · 0 comments · Fixed by #3297
Labels
cleanup Code health cleanups documentation Improvements or additions to documentation DX Developer Experience help-wanted great first issue or place to start for our open source community members 👕 T-Shirt LG

Comments

@benhammondmusic
Copy link
Collaborator

benhammondmusic commented Apr 16, 2024 •
edited

There are no automated tests in place for the express app within frontend_server. Although it's pretty basic, we should still add coverage to ensure changes to the code won't break the service, particularly because the service it rarely run locally, and appears as a terraform error when the broken service is deployed.

Before proceeding with any dependabot PRs that upgrade this package json, including node_fetch (which should probably be removed in favors of Node 18+'s built in fetch()) and the proxy authentication package that's out of date, we should have tests for each of the main functions in place that are run alongside the frontend and python unit tests

  • implement comprehensive test coverage
  • go back and upgrade the poxy auth package
  • go back and either remove or update the node_fetch package
@benhammondmusic benhammondmusic added documentation Improvements or additions to documentation cleanup Code health cleanups DX Developer Experience help-wanted great first issue or place to start for our open source community members 👕 T-Shirt LG labels Apr 16, 2024
@benhammondmusic benhammondmusic mentioned this issue May 15, 2024
Merged
benhammondmusic added a commit that referenced this issue May 15, 2024
@benhammondmusic
Updates frontend server, adds Tests (#3297)
15fac75 
# Description and Motivation
<!--- bulleted, high level items. use keywords (eg "closes #144" or
"fixes #4323") -->
 
- closes #3152
- refactors from commonjs requires() to esmodule import() style
- re-enables dependabot on frontend server deps
- enables super linter on frontend_server
- refactors to use built in node fetch
- pins node version (required due to built in fetch)

## Has this been tested? How?

- new tests fails when intentionally breaking the code

## Screenshots (if appropriate)

<img width="757" alt="Screenshot 2024-05-14 at 11 51 10 PM"
src="https://github.com/SatcherInstitute/health-equity-tracker/assets/41567007/0a7b0bbd-b28d-453c-a692-55e6d98a6d2f">

## Types of changes

(leave all that apply)

- Refactor / chore

## New frontend preview link is below in the Netlify comment 😎
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code health cleanups documentation Improvements or additions to documentation DX Developer Experience help-wanted great first issue or place to start for our open source community members 👕 T-Shirt LG
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates frontend server, adds Tests benhammondmusic/health-equity-tracker
1 participant
@benhammondmusic