Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates frontend server, adds Tests #3297

Merged

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented May 15, 2024

Description and Motivation

  • closes Need tests for frontend_server #3152
  • refactors from commonjs requires() to esmodule import() style
  • re-enables dependabot on frontend server deps
  • enables super linter on frontend_server
  • refactors to use built in node fetch
  • pins node version (required due to built in fetch)

Has this been tested? How?

  • new tests fails when intentionally breaking the code

Screenshots (if appropriate)

Screenshot 2024-05-14 at 11 51 10 PM

Types of changes

(leave all that apply)

  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented May 15, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9000776
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66444bfaf8b52a0008f5baa5
😎 Deploy Preview https://deploy-preview-3297--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic changed the title Updates and Tests frontend server Updates frontend server, adds Tests May 15, 2024
@benhammondmusic benhammondmusic marked this pull request as ready for review May 15, 2024 14:00
@benhammondmusic benhammondmusic merged commit 15fac75 into SatcherInstitute:main May 15, 2024
7 checks passed
@benhammondmusic benhammondmusic deleted the tests-frontend-server branch May 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need tests for frontend_server
1 participant