Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: should be pop_pct not raw population counts? #3185

Closed
benhammondmusic opened this issue Apr 23, 2024 · 0 comments · Fixed by #3186
Closed

Bug: should be pop_pct not raw population counts? #3185

benhammondmusic opened this issue Apr 23, 2024 · 0 comments · Fixed by #3186
Assignees
@eriwarr
Labels
bug Something isn't working cleanup Code health cleanups Python 👕 T-Shirt SM

Comments

@benhammondmusic
Copy link
Collaborator

health-equity-tracker/python/datasources/cdc_wisqars_youth.py

Lines 134 to 136 in ddf9acd

std_col.GUN_DEATHS_YOUNG_ADULTS_POPULATION
if col == std_col.GUN_DEATHS_YOUNG_ADULTS_PREFIX
else std_col.GUN_DEATHS_YOUTH_POPULATION

Looking at the util fn signature for calculating pct_rel_inequity and the way it's used elsewhere, I believe the function needs the name of the population percent share column, not the raw population counts columns
@benhammondmusic benhammondmusic added bug Something isn't working cleanup Code health cleanups 👕 T-Shirt SM Python labels Apr 23, 2024
@eriwarr eriwarr mentioned this issue Apr 23, 2024
Merged
2 tasks
eriwarr added a commit that referenced this issue Apr 23, 2024
@eriwarr
Fix: Use Population Percentage Instead of Raw Population Counts (#3186)
6851562 
Fix #3185: Use population percentage for relative inequity calculations and update docstring placement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriwarr eriwarr

Labels
bug Something isn't working cleanup Code health cleanups Python 👕 T-Shirt SM
Projects
HET Board
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Use Population Percentage Instead of Raw Population Counts eriwarr/health-equity-tracker
2 participants
@benhammondmusic @eriwarr