Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test - add cypress data-cy labels + update jest test #301

Merged
merged 8 commits into from
Nov 24, 2021

Conversation

stavares843
Copy link
Member

@stavares843 stavares843 commented Nov 23, 2021

What this PR does 📖

  • Updates Cypress version from 9.0.0 to 9.1.0
  • Adds data-cy labels on Create.html on the username/status fields and the sign-in button
  • Adds the data-cy labels on the test
  • Minor update when verifying a copy
  • Fix errors on VSCode related to Jest test
  • Adds @types/jest and @types/node

Which issue(s) this PR adds 🔨

AP-53
AP-54

Special notes for reviewers 🗒️

N/A

Additional comments 🎤

N/A

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Nov 23, 2021
@stavares843 stavares843 changed the title test - add cypress data-cy labels test - add cypress data-cy labels + fix jest test Nov 23, 2021
@stavares843
Copy link
Member Author

/rebase

@stavares843 stavares843 changed the title test - add cypress data-cy labels + fix jest test test - add cypress data-cy labels + update jest test Nov 23, 2021
@InfamousVague InfamousVague merged commit bdf19ae into dev Nov 24, 2021
@InfamousVague InfamousVague deleted the sara/cypress-data-cy-labels branch November 24, 2021 06:25
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Nov 24, 2021
InfamousVague pushed a commit that referenced this pull request Dec 5, 2021
* chore - update cypress version

* chore - add data-cy labels

* chore - add data-cy labels on test

* chore - fix jest test

* chore - update jest file name

* chore - update test file

* chore - minor update to test file

Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants