Skip to content

Commit

Permalink
Merge pull request #117 from Ichimonji10/ssh-nopty
Browse files Browse the repository at this point in the history
Disable PTY when working with docker init script
  • Loading branch information
elyezer committed Jan 19, 2015
2 parents 2fd9254 + 3c614ee commit 4291f62
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion automation_tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,14 @@ def setup_default_docker():
if os_version >= 7:
run('systemctl restart docker')
else:
run('service docker restart')
# This can silently fail if a pseuo-terminals is used, due to docker's
# non-standard approach to daemonizing and its naive init script. See:
#
# https://github.com/fabric/fabric/issues/395#issuecomment-1846383
# https://github.com/fabric/fabric/issues/395#issuecomment-32219270
# https://github.com/docker/docker/issues/2758
#
run('service docker restart', pty=False)

# Check that things look good
run('docker ps')
Expand Down

0 comments on commit 4291f62

Please sign in to comment.