Task to configure system for email notification. #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| hostname = run('hostname', quiet=True).strip() | ||
| if hostname: | ||
| domain = hostname.split('.', 1)[1] |
There was a problem hiding this comment.
I am not sure about the purpose of the domain value. Can you please test and make sure that this actually works?
There was a problem hiding this comment.
Tested and it didn't seem to affect the end result. I still managed to get notifications. If anything, the default for domain is something like example.com which my proposed code would change.
There was a problem hiding this comment.
I think I want to remove the code that updates the domain attribute as I don't think it buy us anything
|
ACK, pending comment |
omaciel
force-pushed
the
setup-email-notification
branch
from
c861a61
to
e7bfe1c
Compare
| call it, preferably before another task that restarts the stack, such as | ||
| the 'setup_default_capsule' task. | ||
|
|
||
| :param str smtp: A valid URL to a SMTP server. |
|
ACK |
This task will configure your Satellite 6 system to send out email notifications. The task itself needs to restart the entire stack in order to take effect (via katello-service restart). I chose not to restart the stack within the task itself, but to let the user call it when appropriate, preferably before another task that may already restart all services, such as the ``setup_default_capsule`` task.
omaciel
force-pushed
the
setup-email-notification
branch
from
e7bfe1c
to
8e6e8dc
Compare
|
I decided to drop the code that updated the |
|
ACK |
|
Time to merge |
elyezer
added a commit
that referenced
this pull request
Mar 17, 2015
Task to configure system for email notification.
|
Karma given |
|
I can haz beers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task will configure your Satellite 6 system to send out email
notifications. The task itself needs to restart the entire stack in
order to take effect (via katello-service restart). I chose not to
restart the stack within the task itself, but to let the user call it
when appropriate, preferably before another task that may already
restart all services, such as the
setup_default_capsuletask.