update_rpms functionality #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1399,3 +1399,12 @@ def run_errata(): | |||
| .format(package2, os.environ['ERRATA_NUMBER'], package2)) | |||
| # After this you can see the upgraded packages | |||
| # Run `<package2>-downgrade` if you want to revert to the old packages | |||
|
|
|||
| def update_rpms(): | |||
There was a problem hiding this comment.
Since this command would update the entire system, I'd vote for update_system since update_packages to me implies that only certain packages would be updated :)
|
@cswiii maybe you could update all places where we call out |
|
ACK |
|
oops, reused old commit message, but it is now update_system |
|
@cswiii not a blocker but how about calling the new method whenever there's a |
|
ACK |
1 similar comment
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly take care of issue #71