Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Import - automation run in concurrent threads breaks asserts #3291

Closed
lpramuk opened this issue Feb 15, 2016 · 4 comments
Closed

CLI Import - automation run in concurrent threads breaks asserts #3291

lpramuk opened this issue Feb 15, 2016 · 4 comments
Assignees
@rplevka
Labels
Bug This is an issue with the robottelo framework CLI Issues and PRs involving the CLI

Comments

@lpramuk
Copy link
Contributor

lpramuk commented Feb 15, 2016

For asserts we cannot rely on testing environment isolation as other thread can change testing environment in the meantime.

Example: test negative import organizations

  • list orgs
  • try to import org (negative: No action taken.)
  • list orgs
  • assert org lists are identical [FAIL]
@lpramuk lpramuk added Bug This is an issue with the robottelo framework CLI Issues and PRs involving the CLI labels Feb 15, 2016
@elyezer elyezer mentioned this issue Mar 30, 2016
Closed
@rplevka rplevka self-assigned this Mar 30, 2016
@rplevka
Copy link
Member

rplevka commented Mar 30, 2016

we decided with @elyezer to implement a standalone job for transitions job:

SatelliteQE/robottelo-ci#230

  • will remove the @tier decorators after jenkins job is prepared

@elyezer
Copy link
Contributor

elyezer commented Mar 30, 2016

It is not gonna be a standalone job, but an additional step on tier1 job which will run transitioning tests in serial and then Jenkin will join both results tier1 and transitioning when doing the report.

@rplevka
Copy link
Member

rplevka commented Mar 30, 2016

@elyezer 👍

rplevka added a commit to rplevka/robottelo that referenced this issue Mar 30, 2016
@rplevka
part of a fix of SatelliteQE#3291 - removing tier decorators
d593ee4
@rplevka rplevka mentioned this issue Mar 30, 2016
Merged
rplevka added a commit to rplevka/robottelo that referenced this issue Mar 30, 2016
@rplevka
part of a fix of SatelliteQE#3291 - removing tier decorators
92e218c
omaciel added a commit that referenced this issue Mar 30, 2016
@omaciel
Merge pull request #3366 from rplevka/import_tiers
7e12cd8 
part of a fix of #3291 - removing tier decorators for Import tests
@elyezer
Copy link
Contributor

elyezer commented Mar 30, 2016

SatelliteQE/robottelo-ci#231 and #3366 are merged. We are safe to close this now.

@elyezer elyezer closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rplevka rplevka

Labels
Bug This is an issue with the robottelo framework CLI Issues and PRs involving the CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elyezer @lpramuk @rplevka