Add docker compute resource API creation tests #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -296,13 +298,22 @@ class ComputeResource( | |||
| """A representation of a Compute Resource entity.""" | |||
| description = entity_fields.StringField(null=True) | |||
| # `name` cannot contain whitespace. Thus, the chosen string types. | |||
| name = entity_fields.StringField(null=True, str_type=('alphanumeric', 'cjk')) | |||
| name = entity_fields.StringField( | |||
| required=True, str_type=('alphanumeric', 'cjk')) | |||
There was a problem hiding this comment.
API docs now shows name as being required
| # {server_hostname} variable can be used and will be replaced by | ||
| # main.server.hostname value. | ||
| internal_url=http://{server_hostname}:2375 | ||
| # Internal docker URL in the format http[s]://<server>:<port>. |
|
Great job. ACK |
| # Internal docker URL in the format http[s]://<server>:<port>. The | ||
| # {server_hostname} variable can be used and will be replaced by | ||
| # main.server.hostname value. | ||
| internal_url=http://{server_hostname}:2375 |
There was a problem hiding this comment.
This could be internal_url=http://localhost:2375 instead.
|
ACK pending comments |
Before writing the tests was needed to: * Update ComputeResource to deal with the Docker provider. * Add configuration in the robottelo.properties file to configure the docker internal and external server URLs. * Add helpers to get the internal and external docker server URLs. This will make easier to get the config without having to deal with the config object every time. The above allowed write tests for creating internal and external Docker-based compute resources, also added on this commit.
elyezer
force-pushed
the
docker-compute-resource-tests
branch
from
e9d0392
to
67a8ef1
Compare
|
Looks great. @omaciel's comment has been addressed too. |
Ichimonji10
added a commit
that referenced
this pull request
Feb 27, 2015
Add docker compute resource API creation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before writing the tests was needed to:
docker internal and external server URLs.
will make easier to get the config without having to deal with the
config object every time.
The above allowed write tests for creating internal and external
Docker-based compute resources, also added on this commit.