Added a new requirements file for storing pip freeze results #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APT |
|
We have a bunch of requirements that are not for running robottelo but syntax/code style checking and also NailGun is missing in the list. |
|
ACK, pending comment. |
|
I installed my virtualenv using requirements-optional.txt and did a pip freeze. Right now, there is no distinction in requirements-optional.txt to identify the libraries needed just to run robottelo vs. code style checking libraries. So I believe it is okay to leave it as such.
|
|
Nailgun dependency is now added. This PR is ready for review again. |
|
ACK |
elyezer
added a commit
that referenced
this pull request
Mar 1, 2016
Added a new requirements file for storing pip freeze results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.