Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.2.z] productize _gen_mac_for_libvirt() #4200

Merged
merged 1 commit into from
Jan 20, 2017
Merged

[6.2.z] productize _gen_mac_for_libvirt() #4200

merged 1 commit into from
Jan 20, 2017

Conversation

rplevka
Copy link
Member

@rplevka rplevka commented Jan 18, 2017 •
edited
Loading

cherry-pick of #4194

In [4]: g = LibvirtGuest(extra_nic=True)

In [5]: g.create()
2017-01-18 11:01:49 - robottelo.ssh - INFO - Instantiated Paramiko client 0x7fe8bdd6b650
2017-01-18 11:01:49 - robottelo.ssh - DEBUG - Connected to [libvirt1.satellite.com]
2017-01-18 11:01:49 - robottelo.ssh - DEBUG - >>> virt-install --hvm --network=bridge:downstream_el6 --mac=c6:d7:f1:b5:40:1f --name=macc6d7f1b5401f.satellite.com --ram=1024 --vcpus=1 --os-type=linux --os-variant=rhel7 --disk pat
2017-01-18 11:01:52 - robottelo.ssh - DEBUG - <<< stdout

Starting install...
Allocating 'macc6d7f1b5401f.satellite.c | 8.0 GB  00:00·····
Creating domain...                                          |    0 B  00:00·····
Domain installation still in progress. You can reconnect to·
the console to complete the installation process.

2017-01-18 11:01:52 - robottelo.ssh - INFO - Destroying Paramiko client 0x7fe8bdd6b650
2017-01-18 11:01:52 - robottelo.ssh - INFO - Destroyed Paramiko client 0x7fe8bdd6b650

In [6]: g.attach_nic()
2017-01-18 11:01:57 - robottelo.ssh - INFO - Instantiated Paramiko client 0x7fe8bdd6be50
2017-01-18 11:01:57 - robottelo.ssh - DEBUG - Connected to [libvirt1.satellite.com]
2017-01-18 11:01:57 - robottelo.ssh - DEBUG - >>> virsh attach-interface --domain=macc6d7f1b5401f.satellite.com --type=bridge --source=downstream_el6 --model=virtio --mac=ee:0c:95:2e:e0:5b --config
2017-01-18 11:01:58 - robottelo.ssh - DEBUG - <<< stdout
Interface attached successfully


2017-01-18 11:01:58 - robottelo.ssh - INFO - Destroying Paramiko client 0x7fe8bdd6be50
2017-01-18 11:01:58 - robottelo.ssh - INFO - Destroyed Paramiko client 0x7fe8bdd6be50

@rplevka rplevka added the 6.2 label Jan 18, 2017
@rplevka rplevka self-assigned this Jan 18, 2017
@rplevka rplevka added the review label Jan 18, 2017
@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.022% when pulling c461afd on rplevka:6.2.z_gen_mac_prod into b3b4d09 on SatelliteQE:6.2.z.

rochacbruno
rochacbruno suggested changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending comment

robottelo/libvirt_discovery.py
for _ in range(0, 10):
mac = gen_mac(multicast=False, locally=True)
if not mac.startswith(u'fe'):
return(mac)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, return mac

@coveralls
Copy link

coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.022% when pulling b97c319 on rplevka:6.2.z_gen_mac_prod into b3b4d09 on SatelliteQE:6.2.z.

@pondrejk pondrejk merged commit aa2020b into SatelliteQE:6.2.z Jan 20, 2017
@rplevka rplevka deleted the 6.2.z_gen_mac_prod branch March 21, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@sghai sghai Awaiting requested review from sghai

Assignees

@rplevka rplevka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rplevka @coveralls @rochacbruno @pondrejk