[6.2.z] refactored vm.py #4412

rplevka · 2017-03-09T13:44:15Z

moved sleep logic to the hypervisor
fixed cli.activation_key test cases - updated the assertions

 generated xml file: /home/jenkins/workspace/satellite6-standalone-automation/foreman-results.xml 
=================== 2 tests deselected by "-m 'not stubbed'" ===================
============ 42 passed, 4 skipped, 2 deselected in 2388.99 seconds =============
+ exit 0
Deleting 1 temporary files
Recording test results

Archiving artifacts
Started calculate disk usage of build
Finished Calculation of disk usage of build in 0 seconds
Started calculate disk usage of workspace
Finished Calculation of disk usage of workspace in 0 seconds
Finished: SUCCESS

partly addresses #4153

mention-bot · 2017-03-09T13:44:17Z

@rplevka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbidarkar, @abalakh and @oshtaier to be potential reviewers.

rplevka · 2017-03-09T13:49:38Z

robottelo/vm.py

        result = ssh.command(
-            u'ping -c 1 {0}.local'.format(self._target_image),
+            u'for i in {{1..60}}; do ping -c1 {0}.local && break; sleep 1;'
+            u' done; echo $?'.format(self._target_image),


this will move the timeout logic onto the hypervisor itself, so it keeps pinging the host for availability until ready or timeout passes. This speeds up things a bit since we don't wait a constant time (full minute) everytime. After testing, the host typically boots up whithin ~30seconds.

It is good that we may save time here, but with my past experience at times certain services take more time to pass by for it to be able to work properly. so I feel let's keep a watch if client tests start failing for weird reasons.
For now I think we can give a try.
Update: Also I feel this could be a problem with RHEL7 as with systemd, services get started in parallel, so services which are waiting for/on network to be availble , may fail to work properly as they are still trying to come up. Also we may be waiting here for very short period instead of the previous 60 secs.

This could help may be, if we face any issue. https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

@kbidarkar I was thinking about trying to ssh in a loop instead of pinging the host. That would ensure we cut the loop after we are really able to connect to tcp/22.

your other comment is an interesting read, however i would avoid this solution if we can, as it involves changing the settings on the virtual host, which would require changes to the base image. We would loose flexibility with this as we might decide to dynamically deploy systems with various system, not necessarily using pre-built base images, etc.

what do you think?

rplevka · 2017-03-09T13:50:23Z

robottelo/vm.py

@@ -291,7 +289,8 @@ def register_contenthost(self, org, activation_key=None, lce=None,
        if force:
            cmd += u' --force'
        result = self.run(cmd)
-        if result.return_code == 0:
+        if (u'The system has been registered with ID' in
+                u''.join(result.stdout)):
            self._subscribed = True


this part has already existed, so why not use it.

rplevka · 2017-03-09T13:50:47Z

tests/foreman/cli/test_activationkey.py

@@ -558,11 +558,12 @@ def test_positive_usage_limit(self):
                vm1.install_katello_ca()
                result = vm1.register_contenthost(
                    self.org['label'], new_ak['name'])
-                self.assertEqual(result.return_code, 0)
+                self.assertTrue(vm1._subscribed)


using the _subscribed attribute since it exists.

@rplevka , you are accessing a private attr instead of doing so and as you are refactoring VirtualMachine you can add a property in VirtualMachine class:

class VirtualMachine(object): ... @property def subscribed(self): return self._subscribed

and use it as:

... self.assertTrue(vm1.subscribed) ...

Thanks @ldjebran, great point. Will do that.

oshtaier · 2017-03-09T14:01:43Z

APT

coveralls · 2017-03-09T16:01:44Z

Coverage decreased (-0.03%) to 69.073% when pulling 351f024 on rplevka:6.2.z_host_subscribe into 6863892 on SatelliteQE:6.2.z.

rplevka · 2017-03-15T17:20:12Z

robottelo/vm.py

            self.provisioning_server
        )
        if result.return_code != 0:
            raise VirtualMachineError(
                'Failed to fetch virtual machine IP address information')
        output = ''.join(result.stdout)
        self.ip_addr = output.split('(')[1].split(')')[0]
+        ssh_check = ssh.command(


this will continuously check for ssh availability

rplevka · 2017-03-15T17:20:58Z

@kbidarkar could you review this once again?
I've added a loop for checking the ssh port status before we proceed.

rochacbruno · 2017-03-16T16:03:49Z

@rplevka travis CI is failing test_vm StopIteration on mock.

rplevka · 2017-03-16T16:38:31Z

@rochacbruno just fixed it, let's wait for the re-run

coveralls · 2017-03-16T16:41:39Z

Coverage increased (+0.04%) to 68.599% when pulling 0f5da54 on rplevka:6.2.z_host_subscribe into 8f32274 on SatelliteQE:6.2.z.

fixed cli.activation_key test cases - updated the assertions

coveralls · 2017-03-16T17:23:27Z

Coverage decreased (-0.05%) to 68.599% when pulling e630032 on rplevka:6.2.z_host_subscribe into a11d87e on SatelliteQE:6.2.z.

rochacbruno

ACK

rplevka self-assigned this Mar 9, 2017

rplevka added review CLI Issues and PRs involving the CLI TestFailure Issues and PRs related to a test failing in automation labels Mar 9, 2017

rplevka commented Mar 9, 2017

View reviewed changes

rplevka force-pushed the 6.2.z_host_subscribe branch from 42cc9db to 351f024 Compare March 9, 2017 15:54

rplevka added the DO NOT MERGE label Mar 10, 2017

rplevka force-pushed the 6.2.z_host_subscribe branch 2 times, most recently from 32b5ded to 33fb6b5 Compare March 15, 2017 17:17

rplevka removed the DO NOT MERGE label Mar 15, 2017

rplevka commented Mar 15, 2017

View reviewed changes

rplevka requested review from kbidarkar, sghai and lpramuk March 15, 2017 17:21

refactored vm.py - moved sleep logic to the hypervisor

e630032

fixed cli.activation_key test cases - updated the assertions

rplevka force-pushed the 6.2.z_host_subscribe branch from 0f5da54 to e630032 Compare March 16, 2017 17:18

rplevka changed the title ~~refactored vm.py~~ [6.2.z] refactored vm.py Mar 16, 2017

rochacbruno approved these changes Mar 16, 2017

View reviewed changes

rochacbruno merged commit f6c87e3 into SatelliteQE:6.2.z Mar 16, 2017

rochacbruno removed review TestFailure Issues and PRs related to a test failing in automation labels Mar 16, 2017

rplevka mentioned this pull request Mar 20, 2017

refactored vm.py #4471

Merged

ldjebran mentioned this pull request Aug 11, 2017

[6.3] FIX CLI test_positive_register_host_ak_with_host_collection #5129

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[6.2.z] refactored vm.py #4412

[6.2.z] refactored vm.py #4412

rplevka commented Mar 9, 2017 •

edited

Loading

mention-bot commented Mar 9, 2017

rplevka Mar 9, 2017

kbidarkar Mar 9, 2017 •

edited

Loading

kbidarkar Mar 9, 2017

rplevka Mar 10, 2017

rplevka Mar 9, 2017

rplevka Mar 9, 2017

ldjebran Mar 9, 2017 •

edited

Loading

rplevka Mar 10, 2017

oshtaier commented Mar 9, 2017

coveralls commented Mar 9, 2017 •

edited

Loading

rplevka Mar 15, 2017

rplevka commented Mar 15, 2017

rochacbruno commented Mar 16, 2017

rplevka commented Mar 16, 2017

coveralls commented Mar 16, 2017 •

edited

Loading

coveralls commented Mar 16, 2017 •

edited

Loading

rochacbruno left a comment

[6.2.z] refactored vm.py #4412

[6.2.z] refactored vm.py #4412

Conversation

rplevka commented Mar 9, 2017 • edited Loading

mention-bot commented Mar 9, 2017

rplevka Mar 9, 2017

Choose a reason for hiding this comment

kbidarkar Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

kbidarkar Mar 9, 2017

Choose a reason for hiding this comment

rplevka Mar 10, 2017

Choose a reason for hiding this comment

rplevka Mar 9, 2017

Choose a reason for hiding this comment

rplevka Mar 9, 2017

Choose a reason for hiding this comment

ldjebran Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

rplevka Mar 10, 2017

Choose a reason for hiding this comment

oshtaier commented Mar 9, 2017

coveralls commented Mar 9, 2017 • edited Loading

rplevka Mar 15, 2017

Choose a reason for hiding this comment

rplevka commented Mar 15, 2017

rochacbruno commented Mar 16, 2017

rplevka commented Mar 16, 2017

coveralls commented Mar 16, 2017 • edited Loading

coveralls commented Mar 16, 2017 • edited Loading

rochacbruno left a comment

Choose a reason for hiding this comment

rplevka commented Mar 9, 2017 •

edited

Loading

kbidarkar Mar 9, 2017 •

edited

Loading

ldjebran Mar 9, 2017 •

edited

Loading

coveralls commented Mar 9, 2017 •

edited

Loading

coveralls commented Mar 16, 2017 •

edited

Loading

coveralls commented Mar 16, 2017 •

edited

Loading