Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access subscription page with non admin user (BZ1399725) #4631

Merged
merged 1 commit into from
May 15, 2017
Merged

Access subscription page with non admin user (BZ1399725) #4631

merged 1 commit into from
May 15, 2017

Conversation

oshtaier
Copy link
Contributor

Submitting first in 6.2.z as in 6.3 Viewer role was changed and defect should has some deviations from its description.

Behavior:
image

nosetests tests/foreman/ui/test_subscription.py -m test_positive_access_with_non_admin_user
S
----------------------------------------------------------------------
Ran 1 test in 16.589s

OK (SKIP=1)

@oshtaier oshtaier added 6.2 QETestCoverage Issues and PRs relating to a Satellite bug UI Issues and PRs involving the UI labels Apr 28, 2017
@oshtaier oshtaier self-assigned this Apr 28, 2017
@mention-bot
Copy link

@oshtaier, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbidarkar, @sghai and @abalakh to be potential reviewers.

pondrejk
pondrejk approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending travis

renzon
renzon approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending travis

@coveralls
Copy link

coveralls commented May 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 40.146% when pulling 40ab0ad on oshtaier:subs_viewer into c4b6303 on SatelliteQE:6.2.z.

@renzon renzon merged commit a94bd86 into SatelliteQE:6.2.z May 15, 2017
@renzon renzon removed the review label May 15, 2017
@oshtaier oshtaier deleted the subs_viewer branch May 22, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzon renzon renzon approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@oshtaier oshtaier

Labels
QETestCoverage Issues and PRs relating to a Satellite bug UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oshtaier @mention-bot @coveralls @renzon @pondrejk