Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test rex connect by ip #4648

Merged
merged 1 commit into from
Jun 14, 2017
Merged

test rex connect by ip #4648

merged 1 commit into from
Jun 14, 2017

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented May 5, 2017

Related to #4624 tests TBA

@pondrejk pondrejk added 6.3 CLI Issues and PRs involving the CLI UI Issues and PRs involving the UI labels May 5, 2017
@pondrejk pondrejk self-assigned this May 5, 2017
@mention-bot
Copy link

@pondrejk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JacobCallahan, @oshtaier and @abalakh to be potential reviewers.

@pondrejk pondrejk added review and removed review labels May 5, 2017
@coveralls
Copy link

coveralls commented May 5, 2017 •
edited

Coverage Status

Coverage remained the same at 40.299% when pulling c8c4365 on pondrejk:remote_execution_connect_by_ip into 6a63d9a on SatelliteQE:master.

renzon
renzon approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch 3 times, most recently from d4e1741 to 4dbf84f Compare May 9, 2017 14:12
@pondrejk pondrejk removed DO NOT MERGE UI Issues and PRs involving the UI labels May 9, 2017
@pondrejk
Copy link
Contributor Author

pondrejk commented May 9, 2017

I realized the UI part needs some more work so I decided to move it to a separate commit, test results for the cli part:

nosetests -v tests/foreman/cli/test_remoteexecution.py:RemoteExecutionTestCase.test_positive_run_default_job_template_by_ip
Run default template on host connected via ip ... ok

----------------------------------------------------------------------
Ran 1 test in 590.237s

OK

nosetests -v tests/foreman/cli/test_remoteexecution.py:RemoteExecutionTestCase.test_positive_run_custom_job_template_by_ip
Run custom template on host connected via ip ... ok

----------------------------------------------------------------------
Ran 1 test in 601.654s

OK

@pondrejk pondrejk mentioned this pull request May 9, 2017
Merged
@coveralls
Copy link

coveralls commented May 10, 2017 •
edited

Coverage Status

Coverage remained the same at 40.299% when pulling 2e7b2e7 on pondrejk:remote_execution_connect_by_ip into 29c99ba on SatelliteQE:master.

oshtaier
oshtaier reviewed May 10, 2017
View reviewed changes
tests/foreman/cli/test_remoteexecution.py Outdated

:expectedresults: Verify the job was successfully ran against the host
"""
Settings.set({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment here about try...finally block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshtaier addressed, ok with this form?

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch from 4dbf84f to 679cbf4 Compare May 12, 2017 09:05
@coveralls
Copy link

coveralls commented May 12, 2017 •
edited

Coverage Status

Coverage remained the same at 40.338% when pulling 679cbf4 on pondrejk:remote_execution_connect_by_ip into 7bce1c4 on SatelliteQE:master.

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch from 679cbf4 to 39977aa Compare May 12, 2017 14:44
@coveralls
Copy link

coveralls commented May 12, 2017 •
edited

Coverage Status

Coverage remained the same at 40.338% when pulling 39977aa on pondrejk:remote_execution_connect_by_ip into 375f169 on SatelliteQE:master.

@pondrejk
Copy link
Contributor Author

Hello, after some research and discussion with @rplevka, I decided to take a different approach to these tests (using per-host setting instead of global setting). Therefore I put do_not_merge. Also this can help us to get more rex tests running in automation until the problems from #4578 are resolved

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch 2 times, most recently from 5f799ab to db5ced6 Compare May 22, 2017 13:26
@codecov
Copy link

codecov bot commented May 22, 2017 •
edited

Codecov Report

Merging #4648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4648   +/-   ##
=======================================
  Coverage   41.21%   41.21%           
=======================================
  Files          88       88           
  Lines        7163     7163           
=======================================
  Hits         2952     2952           
  Misses       4211     4211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e863f3...c26c607. Read the comment docs.

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch from db5ced6 to 7b4c8d1 Compare May 31, 2017 08:43
@pondrejk
Copy link
Contributor Author

pondrejk commented May 31, 2017 •
edited

@renzon @oshtaier ready for review again, I enable the remote_execution_connect_by_ip per host, I added more tests -- these are by_ip version of existing tests. Tests:

py.test tests/foreman/cli/test_remoteexecution.py -k _by_ip 
========================================= test session starts ==========================================
platform linux2 -- Python 2.7.11, pytest-2.9.2, py-1.4.33, pluggy-0.3.1
rootdir: /home/pondrejk/Documents/robottelo, inifile: 
plugins: xdist-1.15.0, services-1.1.14, html-1.10.0, cov-2.3.1
collected 21 items 
2017-05-31 10:27:44 - conftest - DEBUG - Deselect of WONTFIX BZs is disabled in settings


tests/foreman/cli/test_remoteexecution.py .....s

================================== 15 tests deselected by '-k_by_ip' ===================================
========================= 5 passed, 1 skipped, 15 deselected in 569.50 seconds =========================

Also added a skip for two tests due to https://bugzilla.redhat.com/show_bug.cgi?id=1451675

renzon
renzon approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip branch from 7b4c8d1 to c26c607 Compare June 13, 2017 14:13
@rplevka rplevka self-requested a review June 14, 2017 12:17
rplevka
rplevka approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member

@rplevka rplevka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rplevka rplevka merged commit c8bcde4 into SatelliteQE:master Jun 14, 2017
@rplevka rplevka removed the review label Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshtaier oshtaier oshtaier left review comments

@renzon renzon renzon approved these changes

@rplevka rplevka rplevka approved these changes

Assignees

@pondrejk pondrejk

Labels
CLI Issues and PRs involving the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pondrejk @mention-bot @coveralls @renzon @oshtaier @rplevka