-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.2.z] cherry-pick test rex connect by ip #4657
[6.2.z] cherry-pick test rex connect by ip #4657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
'name': 'remote_execution_connect_by_ip', | ||
'value': 'True', | ||
}) | ||
invocation_command = make_job_invocation({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should put next statements into try...finally
block to return settings value no matter what result we get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oshtaier addressed, ok with this form?
0535d10
to
0849141
Compare
0849141
to
a365a21
Compare
Hello, after some research and discussion with @rplevka, I decided to take a different approach to these tests (using per-host setting instead of global setting). Therefore I put do_not_merge. Also this can help us to get more rex tests running in automation until the problems from #4578 are resolved |
e6cb7d0
to
a12a256
Compare
@renzon @oshtaier ready for review again, I enable the remote_execution_connect_by_ip per host, I added more tests -- these are by_ip version of existing tests. Tests:
|
Codecov Report
@@ Coverage Diff @@
## 6.2.z #4657 +/- ##
==========================================
- Coverage 40.31% 40.28% -0.03%
==========================================
Files 87 87
Lines 7477 7477
==========================================
- Hits 3014 3012 -2
- Misses 4463 4465 +2
Continue to review full report at Codecov.
|
ACK |
a12a256
to
ab0c355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Cherry-pick from #4648
Related issue: #4624
Test results: