Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2.z] cherry-pick test rex connect by ip #4657

Merged

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented May 9, 2017

Cherry-pick from #4648
Related issue: #4624
Test results:

Run custom template on host connected via ip ... ok

----------------------------------------------------------------------
Ran 1 test in 304.554s

OK

 nosetests -v tests/foreman/cli/test_remoteexecution.py:RemoteExecutionTestCase.test_positive_run_default_job_template_by_ip
Run default template on host connected via ip ... ok

----------------------------------------------------------------------
Ran 1 test in 299.689s

OK

@pondrejk pondrejk added 6.2 CLI Issues and PRs involving the CLI labels May 9, 2017
@pondrejk pondrejk self-assigned this May 9, 2017
@mention-bot
Copy link

@pondrejk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abalakh to be a potential reviewer.

@pondrejk pondrejk added the review label May 9, 2017
@pondrejk pondrejk requested a review from renzon May 9, 2017 15:21
Copy link
Contributor

@renzon renzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

'name': 'remote_execution_connect_by_ip',
'value': 'True',
})
invocation_command = make_job_invocation({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put next statements into try...finally block to return settings value no matter what result we get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshtaier addressed, ok with this form?

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip-6.2.z branch from 0535d10 to 0849141 Compare May 12, 2017 08:56
@coveralls
Copy link

coveralls commented May 12, 2017

Coverage Status

Coverage remained the same at 40.146% when pulling 0849141 on pondrejk:remote_execution_connect_by_ip-6.2.z into c4b6303 on SatelliteQE:6.2.z.

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip-6.2.z branch from 0849141 to a365a21 Compare May 12, 2017 14:50
@coveralls
Copy link

coveralls commented May 12, 2017

Coverage Status

Coverage remained the same at 40.146% when pulling a365a21 on pondrejk:remote_execution_connect_by_ip-6.2.z into c4b6303 on SatelliteQE:6.2.z.

@pondrejk
Copy link
Contributor Author

Hello, after some research and discussion with @rplevka, I decided to take a different approach to these tests (using per-host setting instead of global setting). Therefore I put do_not_merge. Also this can help us to get more rex tests running in automation until the problems from #4578 are resolved

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip-6.2.z branch 3 times, most recently from e6cb7d0 to a12a256 Compare May 31, 2017 11:42
@pondrejk
Copy link
Contributor Author

@renzon @oshtaier ready for review again, I enable the remote_execution_connect_by_ip per host, I added more tests -- these are by_ip version of existing tests. Tests:

py.test tests/foreman/cli/test_remoteexecution.py -k _by_ip 
...
=================== 5 passed, 1 skipped, 15 deselected in 1128.98 seconds ====================

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #4657 into 6.2.z will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            6.2.z    #4657      +/-   ##
==========================================
- Coverage   40.31%   40.28%   -0.03%     
==========================================
  Files          87       87              
  Lines        7477     7477              
==========================================
- Hits         3014     3012       -2     
- Misses       4463     4465       +2
Impacted Files Coverage Δ
robottelo/decorators/func_locker.py 92.12% <0%> (-1.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08abc9f...ab0c355. Read the comment docs.

@renzon
Copy link
Contributor

renzon commented Jun 2, 2017

ACK

@pondrejk pondrejk force-pushed the remote_execution_connect_by_ip-6.2.z branch from a12a256 to ab0c355 Compare June 13, 2017 14:19
@rplevka rplevka self-requested a review June 14, 2017 12:21
Copy link
Member

@rplevka rplevka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rplevka rplevka merged commit 4d04658 into SatelliteQE:6.2.z Jun 14, 2017
@rplevka rplevka removed the review label Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Issues and PRs involving the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants