Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #6923 and also adds controller ansible_variables and ansible_roles #6924

Merged
merged 1 commit into from
May 20, 2019
Merged

Fixes issue #6923 and also adds controller ansible_variables and ansible_roles #6924

merged 1 commit into from
May 20, 2019

Conversation

jameerpathan111
Copy link
Contributor

@jameerpathan111 jameerpathan111 commented May 14, 2019 •
edited
Loading

fixes tests.foreman.api.test_bookmarks.BookmarkTestCase and also adds controller for ansible_variables and ansible_roles.
Fixes issue #6923

$ pytest tests/foreman/api/test_bookmarks.py
=================================================================================== test session starts ===================================================================================

collected 13 items                                                                                                                                                                        

tests/foreman/api/test_bookmarks.py .............                                                                                                                                   [100%]

==================================================================================== warnings summary =====================================================================================
tests/foreman/api/test_bookmarks.py::BookmarkTestCase::test_negative_create_empty_query

======================================================================== 13 passed, 4 warnings in 2303.23 seconds =========================================================================

fixes tests.foreman.api.test_bookmarks.BookmarkTestCase failing due t…
1f28259 
…o "docker_registries is not a valid controller"
@jameerpathan111 jameerpathan111 self-assigned this May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #6924 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6924   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          39       39           
  Lines        4439     4439           
=======================================
  Hits         2782     2782           
  Misses       1657     1657
Impacted Files Coverage Δ
robottelo/constants.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f918d...1f28259. Read the comment docs.

@jameerpathan111 jameerpathan111 changed the title fixes tests.foreman.api.test_bookmarks.BookmarkTestCase failing due to Fixes issue #6923 and also adds controller ansible_variables and ansible_roles May 15, 2019
vijay8451
vijay8451 approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@vijay8451 vijay8451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

omkarkhatavkar
omkarkhatavkar approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@omkarkhatavkar omkarkhatavkar merged commit 34c96e5 into SatelliteQE:master May 20, 2019
@jameerpathan111 jameerpathan111 mentioned this pull request May 20, 2019
Closed
@tpapaioa tpapaioa mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@vijay8451 vijay8451 vijay8451 approved these changes

@jyejare jyejare Awaiting requested review from jyejare

@san7ket san7ket Awaiting requested review from san7ket

Assignees

@jameerpathan111 jameerpathan111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jameerpathan111 @omkarkhatavkar @vijay8451