Remove nailgun.entities imports in tests/foreman/cli

[tpapaioa]

Problem Statement

SAT-22500

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/cli/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

PRT results are the same before and after these changes:

with PR changes:

PRT job #6928:

16:11:32  =========================== short test summary info ============================
16:11:32  FAILED tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_usergroup_sync_with_refresh - robottelo.hosts.IPAHostError: Failed to add the user to usergroup
16:11:32  FAILED tests/foreman/cli/test_repository.py::TestFileRepository::test_positive_upload_file_to_file_repo[0] - assert "Successfully uploaded file 'which-2.19-6.el6.x86_64.rpm'" in 'Successfully uploaded file which-2.19-6.el6.x86_64.rpm'
16:11:32  FAILED tests/foreman/cli/test_repository.py::TestFileRepository::test_file_repo_contains_only_newer_file[0] - assert "Successfully uploaded file 'test-tqpuz.txt'" in 'Successfully uploaded file test-tqpuz.txt'
16:11:32  ERROR tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] - KeyError: 'subscription_status'
16:11:32  = 3 failed, 23 passed, 1819 deselected, 2225 warnings, 1 error in 4149.45s (1:09:09) =

PRT job #7019:

10:59:39  ERROR tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] - KeyError: 'subscription_status'
10:59:39  =================== 8 warnings, 1 error in 771.65s (0:12:51) ===================

master:

PRT job #6924:

11:26:39  =========================== short test summary info ============================
11:26:39  FAILED tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_usergroup_sync_with_refresh - robottelo.hosts.IPAHostError: Failed to add the user to usergroup
11:26:39  FAILED tests/foreman/cli/test_repository.py::TestFileRepository::test_positive_upload_file_to_file_repo[0] - assert "Successfully uploaded file 'which-2.19-6.el6.x86_64.rpm'" in 'Successfully uploaded file which-2.19-6.el6.x86_64.rpm'
11:26:39  FAILED tests/foreman/cli/test_repository.py::TestFileRepository::test_file_repo_contains_only_newer_file[0] - assert "Successfully uploaded file 'test-mjebn.txt'" in 'Successfully uploaded file test-mjebn.txt'
11:26:39  ERROR tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] - KeyError: 'subscription_status'
11:26:39  = 3 failed, 23 passed, 1819 deselected, 2214 warnings, 1 error in 3845.33s (1:04:05) =

PRT job #7020:

11:20:14  ERROR tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] - KeyError: 'subscription_status'
11:20:14  =================== 8 warnings, 1 error in 764.23s (0:12:44) ===================

Related Issues

[tpapaioa]

trigger: test-robottelo
pytest: tests/foreman/cli -k 'test_positive_add_rh_repo_by_id_and_create_filter or test_positive_add_module_stream_filter_rule or test_positive_crud_with_non_admin_user or test_negative_delete_rule_with_non_admin_user or test_positive_create_with_multiple_entities_and_delete or test_positive_refresh_usergroup_with_ad[foobargroup] or test_positive_end_to_end_with_ipa[0] or test_usergroup_sync_with_refresh or test_positive_list_installable_updates or test_positive_associate_scap_policy_with_single_server or test_positive_create_with_auth_yum_repo[0] or test_positive_upload_file_to_file_repo[0] or test_file_repo_contains_only_newer_file[0] or test_positive_delete_manifest_as_another_user or test_positive_update_interval[0] or test_positive_update_sync_date or test_positive_info_enabled_field_is_displayed or test_negative_synchronize_custom_product_past_sync_date or test_positive_synchronize_custom_product_past_sync_date or test_positive_synchronize_custom_product_future_sync_date or test_positive_synchronize_custom_products_future_sync_date or test_positive_synchronize_rh_product_past_sync_date or test_positive_synchronize_rh_product_future_sync_date or test_positive_synchronize_custom_product_daily_recurrence or test_positive_synchronize_custom_product_weekly_recurrence or test_positive_import_force_locked_template or test_positive_CRD_ssh_key'

[Satellite-QE]

PRT Result

Build Number: 6928
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli -k test_positive_add_rh_repo_by_id_and_create_filter or test_positive_add_module_stream_filter_rule or test_positive_crud_with_non_admin_user or test_negative_delete_rule_with_non_admin_user or test_positive_create_with_multiple_entities_and_delete or test_positive_refresh_usergroup_with_ad[foobargroup] or test_positive_end_to_end_with_ipa[0] or test_usergroup_sync_with_refresh or test_positive_list_installable_updates or test_positive_associate_scap_policy_with_single_server or test_positive_create_with_auth_yum_repo[0] or test_positive_upload_file_to_file_repo[0] or test_file_repo_contains_only_newer_file[0] or test_positive_delete_manifest_as_another_user or test_positive_update_interval[0] or test_positive_update_sync_date or test_positive_info_enabled_field_is_displayed or test_negative_synchronize_custom_product_past_sync_date or test_positive_synchronize_custom_product_past_sync_date or test_positive_synchronize_custom_product_future_sync_date or test_positive_synchronize_custom_products_future_sync_date or test_positive_synchronize_rh_product_past_sync_date or test_positive_synchronize_rh_product_future_sync_date or test_positive_synchronize_custom_product_daily_recurrence or test_positive_synchronize_custom_product_weekly_recurrence or test_positive_import_force_locked_template or test_positive_CRD_ssh_key --external-logging
Test Result : = 3 failed, 23 passed, 1819 deselected, 2225 warnings, 1 error in 4149.45s (1:09:09) =

[tpapaioa]

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0]

[Satellite-QE]

PRT Result

Build Number: 7019
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] --external-logging
Test Result : =================== 8 warnings, 1 error in 771.65s (0:12:51) ===================

[vsedmik]

ACK on the phoenix-owned files.