Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pytest-services to 1.3.1, 2.2.0 has a bug for our use of file_lock #8105

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

mshriver
Copy link
Member

pytest-dev/pytest-services#42 should resolve it, if accepted.

I missed this in the update to 2.2.0, committed yesterday.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #8105 into master will decrease coverage by 0.38%.
The diff coverage is 27.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8105      +/-   ##
==========================================
- Coverage   58.56%   58.18%   -0.39%     
==========================================
  Files          74       75       +1     
  Lines        5795     6089     +294     
==========================================
+ Hits         3394     3543     +149     
- Misses       2401     2546     +145     
Impacted Files Coverage Δ
robottelo/cli/factory.py 25.30% <ø> (ø)
robottelo/report_portal/portal.py 25.68% <ø> (+2.10%) ⬆️
robottelo/hosts.py 22.29% <22.29%> (ø)
robottelo/rhsso_utils.py 34.54% <23.07%> (-3.55%) ⬇️
robottelo/config/base.py 62.91% <61.53%> (+0.29%) ⬆️
robottelo/cli/ldapauthsource.py 100.00% <100.00%> (ø)
robottelo/constants/__init__.py 100.00% <100.00%> (ø)
robottelo/decorators/__init__.py 79.01% <0.00%> (-0.48%) ⬇️
robottelo/cli/repository.py 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc222d...b0fceeb. Read the comment docs.

@mshriver mshriver merged commit 44d0e7e into SatelliteQE:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant