Add zc.lockfile.LockError handling to locks.file_lock #42
Conversation
pytest-dev/pytest-services#42 should resolve it, if accepted.
|
@mshriver please add a changelog record and update the authors file |
pytest-dev/pytest-services#42 should resolve it, if accepted.
Following the fix for pytest-dev#38 by pytest-dev#39, I added a timeout loop and exception handling for the exception raised by zc.lockfile Add myself to AUTHORS.rst as contributor Include description of pytest-dev#42 in CHANGES.rst as Unreleased
mshriver
force-pushed
the
fix-zc-lock-file
branch
from
ef78930
to
705bfd8
Compare
| @@ -10,6 +10,7 @@ These people have contributed to `pytest-services`, in alphabetical order: | |||
| * `Dmitrijs Milajevs <dimazest@gmail.com>`_ | |||
| * `Jason R. Coombs <jaraco@jaraco.com>`_ | |||
| * `Joep van Dijken <joepvandijken@github.com>`_ | |||
| * `Magnus Staberg <magnus@staberg.io>`_ | |||
There was a problem hiding this comment.
Keeping with the alphabetical order request at L7
|
@mshriver travis seems to be stuck |
|
@bubenkoff I've noticed travis taking quite some time to start builds, but it looks like it ran and completely successfully since you mentioned it being stuck. That being said, I should add a file_lock unit test, as I don't see one currently. I would hate to fix it for my use and break it for someone else. ** On second look, it is used in the unit tests through |
|
@mshriver thanks, 2.2.1 is out |
|
@bubenkoff Thanks so much! Really appreciate your time to review and merge this. Thanks @StabbarN for the original fix pattern, made it incredibly easy to identify and resolve this issue. |
Following @StabbarN lead for issue #38 and fix in #39, I added a timeout loop and exception handling for the exception raised by zc.lockfile.
Working on getting tox to run for your unit tests, figured I would open the PR in the meanwhile.
Testing against SatelliteQE/Robottelo unit tests where this was encountered after the update to pytest-services 2.2.0 is successful, for what its worth.
This change is