Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise button presses from URL on mount #18

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Visualise button presses from URL on mount #18

merged 1 commit into from
Oct 4, 2023

Conversation

todd-pd
Copy link
Contributor

@todd-pd todd-pd commented Oct 4, 2023

Before

If the page is refreshed after entering a code, or if a URL is visited directly (e.g. pd3-vault-cracker/?code=1234) then the pressed buttons are not highlighted.

before

After

after

@codecov-commenter
Copy link

Codecov Report

Merging #18 (5262d46) into main (815aa35) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          896       899    +3     
  Branches        41        41           
=========================================
+ Hits           896       899    +3     
Files Coverage Δ
src/components/keypad/index.svelte 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SavageCore
Copy link
Owner

Thanks, good catch!

@SavageCore SavageCore merged commit cafacdc into SavageCore:main Oct 4, 2023
2 checks passed
@SavageCore
Copy link
Owner

SavageCore commented Oct 4, 2023

Released as v0.1.3

@todd-pd todd-pd deleted the set-pressed-buttons-on-mount branch October 4, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants