-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battle of Dazar'alor DifficultyString #233
Comments
Hi, This is from a 9/9 Normal lockout showing 11/9 Dump: value="[Battle of Dazar'alor]" |
Hello, This is from 7/9 Normal Lockout showing 9/9 Also, LFR shows 3/18 completed. I couldn't click that one as it does not show up |
I believe I've gathered all the required bit flags. The structure is somewhat different because the second and third bosses aren't identical for both factions, which increases the total number of bosses. It's safe to assume that killing one will set BOTH faction's flags, thereby increasing the total amount that SavedInstances displays by one or two, respectively. Additionally, there seem to be unused entries, but that shouldn't be a problem. Here are the individual flags for each faction, which I collected using this test script:
Notes:
|
Thanks for the update. I guess I should have mentioned that I run Horde. Thought never really crossed my mind that there was an Alliance side, lol. Good work and I'm glad you put this together as I use it frequently. |
4/9HC lockout showing 6/9HC |
Some more values for you from an Alliance player: 1/9M: 5/9H: |
2/6 Heroic (horde): 3/9 Mythic (horde): 9/9 Heroic (horde): Also pinged an alliance friend, and got this: 2/9 Heroic (alliance): I'm still waiting to hear back from a guildy that was only around for our Champions kill in mythic this week, but I fully expect his link to have a bit pattern of 1000. From the comparison of these strings, I suspect your initial expectation was correct. When you kill the first boss, it sets the Champions bit (which is weirdly the 4th bit). When you kill the 2nd boss, regardless of faction, it sets the Grong (horde) and Jadefire Masters (alliance) bits. When you kill the 3rd, it sets the Jadefire Masters (horde) and Grong (alliance) bits. Thus the bit patterns for each level of progression, regardless of faction, should be: X/9 bitmap decimal However, there's anomoly in the comments above. cremor has a 1/9M lockout with a bit pattern of Edit: perhaps not. I had a guildy with our 3/9M lockout invite my (unsaved) hunter, went into the instance, and saved myself, and got a lockout 31 ( LFR seems to have a different issue. My LFR pattern is this: 6/9 LFR (horde): Which is properly counting the number of bosses cleared (oddly) as 6, but showing there being 18 killable bosses rather than just 9. |
For the faction-specific bosses, I suggest simply checking both bits (via OR) and counting either one as one boss regardless of faction. This should work with either combination as long as any one of the bit flags is set by the game, which it should be. If the extra bits are filtered out that way, most users should get an accurate count. The LFR issue probably needs to be looked into. Perhaps it is considering each boss twice? |
@SacredDuckwhale 's table is right, and I am working on this which might be done these days. Mythic is quite different, it marks the other faction bosses true when you kill the first boss, unlike in Normal or Heroic. For LFR, it is because Blizzard have 3 new LFR wings for each faction, but their parent id is the same, so SI add all these wings up and make the number of total bosses is 18, twice of 9. Since we have more Combined LFR issues, like #217, so I'd like to solve it later, as it's not urgent as this. |
Yep, looks to be accurate. My guildie who was there for only Champion (mythic) this week got back to me and had a link with a bit pattern of 13 (1101), which corresponds to Champion and the two alliance bosses. So that would also explain cremor's link, he's alliance and had only killed the first boss that week, and thus had Champion and the two horde bosses flagged. I love it when Blizzard just YOLO's the API... |
SavedInstances uses information in
instancelink
to track how many bosses are defeated. However, there are some problem with BoD'sinstancelink
. Instead of marking a bit in bitmap true for every boss defeated in usual, killing first 3 bosses marking least 5 bits true. So, if first 3 bosses are defeated in your instance,KILLED
is showing 2 more bosses. Here are some example of my own instances00001001101011111
00000000000011111
00000000100011111
10000001101011111
00000000001000000
But I am not sure which two bits are being marked true when first two bosses defeated, so I am looking for help. If you have only killed first one or two bosses, you can help us by following steps.
/dump
to the very head, it will be like/dump "[Battle of Dazar'alor]"
Your help will be very important to us and these workaround.
The text was updated successfully, but these errors were encountered: