Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Optional Foreign HKs for Snowflake #112

Closed
wants to merge 2 commits into from

Conversation

JPLangner
Copy link
Collaborator

Added opportunity to create Non Historized Links on Snowflake without any foreign Hashkeys, as it might be the case that a Non Historized Link exists on its own.

@tkirschke
Copy link
Member

Hi @JPLangner and thanks for reaching out!

I understand the need to make this optional! I have reviewed and tested your code and it works as it should!

But before merging these changes, I have two more requests:

  • Bring these changes on code level also to BigQuery and Exasol
  • Adapt the Wiki to point out, that foreign_hashkeys is now optional

Once these two things are done, I will test again and if it all works, then merge the PR!

Best regards
Tim

@tkirschke
Copy link
Member

Hi @JPLangner , sorry for the late reply here, I saw that you added the optionality for BigQuery and Exasol, thanks!
If you now also add it for Redshift and Postgres, I would merge it!

@JPLangner JPLangner closed this May 30, 2024
@JPLangner JPLangner deleted the nh_link_optional_fk branch May 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants