Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifiers): Unable to add a notifier when no collaborator are specified #784

Conversation

aurelien-reeves-scalingo
Copy link
Contributor

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@aurelien-reeves-scalingo
Copy link
Contributor Author

For info: the issue was due to the new NewStringSlice function to create a StringSlice flag. It considered the empty string as a not-nil default value. That resulted in the resulting []string being an array filed with a single empty string

Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aurelien-reeves-scalingo Are there other StringSlice? Otherwise LGTM

@aurelien-reeves-scalingo
Copy link
Contributor Author

@aurelien-reeves-scalingo Are there other StringSlice? Otherwise LGTM

I did a global search to make sure all of them was fixed

@Soulou Soulou merged commit 61abba6 into master Sep 7, 2022
@Soulou Soulou deleted the fix/notifiers/add_notifier_issue_when_no_collaborator_specified branch September 7, 2022 12:17
@Soulou
Copy link
Member

Soulou commented Sep 7, 2022

Great, let's merge it then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants