feat(publish): compile Windows release on Windows #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
commented
Sep 30, 2022
| @@ -1,7 +1,6 @@ | |||
| name: Test and Release Go CLI | |||
|
|
|||
| on: | |||
| push: | |||
| on: [push] | |||
There was a problem hiding this comment.
This is just a way to write the same things with a different syntax, and I prefer this one.
EtienneM
requested review from
curzolapierre
and removed request for
curzolapierre
curzolapierre
requested changes
Oct 3, 2022
.github/workflows/publish.yml
Outdated
Comment on lines
62
to
64
| - name: List files in the repository | ||
| run: | | ||
| ls ${{ github.workspace }}/dist |
| with: | ||
| go-version-file: "go.mod" | ||
| check-latest: true | ||
| cache: true |
There was a problem hiding this comment.
Out of curiosity, what is the use of this cache property?
There was a problem hiding this comment.
https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs
The action has a built-in functionality for caching and restoring go modules and build outputs.
It should speed up a bit the CI execution.
EtienneM
force-pushed
the
fix/734/windows_build
branch
from
01c8b41
to
d909b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the
publishaction has two different jobs for the GoReleaser execution:releases-windows: execute GoReleaser on a Windows server so that we don't use Go cross compile feature. This is to prevent issues such as the one described in [windows] The CLI doesn't work at all on Windows with command that require an input from the user #734.releases: execute GoReleaser on a Ubuntu server for OpenBSD, Linux and macOS using Go cross compile feature.All these features are added as assets of a single GitHub release. You can see an example of execution on my fork: https://github.com/EtienneM/cli/releases/tag/1.25.2-beta8. One of the cons from my perspective is that we have two different files for the checksums.
Related to #734 and #735
Add a changelog entry in the section "To Be Released" of CHANGELOG.mdno changelog entry, this is an internal change