Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(log-drains): appsignal and syslog tcp+tls examples #816

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

ipfaze
Copy link
Contributor

@ipfaze ipfaze commented Oct 24, 2022

This PR introduce new examples about AppSignal compatibility and the new token parameter for syslog (tcp+tls)
FIX #813

@ipfaze ipfaze marked this pull request as ready for review October 24, 2022 14:05
@curzolapierre
Copy link
Member

Could you add the link the related issue in the description of the PR please?
(FYI: Gitub doc)

@ipfaze
Copy link
Contributor Author

ipfaze commented Oct 25, 2022

Related issue linked 🙂

Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ipfaze ipfaze merged commit cd6ea69 into master Nov 2, 2022
@ipfaze ipfaze deleted the feat/813/log_drain_appsignal_update branch November 2, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LogDrains] With the new features for appsignal and syslog (tcp+tls), the cli help message needs to be updated
2 participants