Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sand client): disable HTTP keepalives to prevent leaking file descriptors #160

Merged
merged 3 commits into from
Nov 23, 2022
Merged

fix(sand client): disable HTTP keepalives to prevent leaking file descriptors #160

merged 3 commits into from
Nov 23, 2022

Conversation

stopostit
Copy link
Contributor

@stopostit stopostit commented Nov 23, 2022 •
edited by jira bot
Loading

Related to SRE-837

@stopostit stopostit self-assigned this Nov 23, 2022
@stopostit stopostit force-pushed the fix/SRE-837/prevent_leaking_file_descriptor branch from e903271 to b50fda2 Compare November 23, 2022 09:53
@stopostit
Copy link
Contributor Author

This will require to change sand.HTTPRoundTripperOpts to include DisableKeepAlives where it is used.
As this may be a breaking change should we publish a new version ?

@stopostit stopostit marked this pull request as ready for review November 23, 2022 10:00
@stopostit stopostit force-pushed the fix/SRE-837/prevent_leaking_file_descriptor branch from b50fda2 to f94b9e7 Compare November 23, 2022 10:07
brandon-welsch
brandon-welsch requested changes Nov 23, 2022
View reviewed changes
client/sand/http.go Outdated Show resolved Hide resolved
client/sand/http.go Outdated Show resolved Hide resolved
cmd/sand-agent-cli/curl.go Outdated Show resolved Hide resolved
@stopostit stopostit force-pushed the fix/SRE-837/prevent_leaking_file_descriptor branch from 3ff82e1 to c15c1d3 Compare November 23, 2022 10:20
brandon-welsch
brandon-welsch approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brandon-welsch
brandon-welsch requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to improve before LGTM

brandon-welsch
brandon-welsch requested changes Nov 23, 2022
View reviewed changes
cmd/sand-agent-cli/curl.go Outdated Show resolved Hide resolved
@stopostit stopostit force-pushed the fix/SRE-837/prevent_leaking_file_descriptor branch from c259049 to 4b1cf1c Compare November 23, 2022 13:29
brandon-welsch
brandon-welsch approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@brandon-welsch brandon-welsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopostit stopostit merged commit 58f8493 into master Nov 23, 2022
@stopostit stopostit deleted the fix/SRE-837/prevent_leaking_file_descriptor branch November 23, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-welsch brandon-welsch brandon-welsch approved these changes

Assignees

@stopostit stopostit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopostit @brandon-welsch