Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCALRCORE-21894 Scalr Provider > Error "Invalid Relationship" while switching between module and vcs provider #130

Merged
merged 10 commits into from
May 23, 2022

Conversation

RomanMytsko
Copy link
Contributor

@RomanMytsko RomanMytsko commented May 10, 2022

Changelog

Documentation

  • I have updated resource/data source documentation in docs

State

  • My changes affect the state
  • I have included a state migration and a unit test for it

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@brezitskiy brezitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be nice to cover a change with a test

Co-authored-by: Anatoliy Brezitskiy <a.brezitskiy@scalr.com>
@@ -138,6 +139,7 @@ func resourceScalrWorkspace() *schema.Resource {
MinItems: 1,
MaxItems: 1,
ConflictsWith: []string{"module_version_id"},
RequiredWith: []string{"vcs_provider_id"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanMytsko we need to cover new changes with tests

@emocharnik emocharnik merged commit 6a7a646 into develop May 23, 2022
@emocharnik emocharnik deleted the fix/SCALRCORE-21894 branch May 23, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants