SCALRCORE-18898 > CLI > User can not change working directory to empty #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 5, 2021 17:34
…ttribute to False and set default value to ''
lbn
suggested changes
Jul 6, 2021
scalr/resource_scalr_workspace.go
Outdated
| @@ -267,6 +267,8 @@ func resourceScalrWorkspaceUpdate(d *schema.ResourceData, meta interface{}) erro | |||
|
|
|||
| if workingDir, ok := d.GetOk("working_directory"); ok { | |||
There was a problem hiding this comment.
Looks like this won't be needed after this change.
lbn
reviewed
Jul 6, 2021
CHANGELOG.md
Outdated
|
|
||
| ### Required | ||
|
|
||
| - scalr server >= `8.0.1-beta.20210616.1` |
There was a problem hiding this comment.
Doesn't look like we need to require a more recent version of Scalr for this change.
lbn
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Documentation
State